ECAL esConsumes migration of CalibCalorimetry packages

[thomreis]

PR description:

The PR migrates ECAL related code in the CalibCalorimetry packages to esConsumes (#31061). In addition getByLabel() calls were replaced by getByToken() and legacy module types were migrated to multithreaded module types.

Modified packages:

• CalibCalorimetry/CaloMiscalibTools
• CalibCalorimetry/EcalLaserAnalyzer
• CalibCalorimetry/EcalPedestalOffsets
• CalibCalorimetry/EcalSRTools
• CalibCalorimetry/EcalTPGTools
• CalibCalorimetry/EcalTrivialCondModules

PR validation:

Code compiles. Where test configurations were present those were run as well.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35077/24958

• This PR adds an extra 216KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibCalorimetry/CaloMiscalibTools/plugins/WriteEcalMiscalibConstants.cc modified in PR(s): Centralise payload ptr ownership for condition updating workflows #35048
  • File CalibCalorimetry/CaloMiscalibTools/plugins/WriteEcalMiscalibConstantsMC.cc modified in PR(s): Centralise payload ptr ownership for condition updating workflows #35048
  • File CalibCalorimetry/EcalSRTools/interface/EcalDccWeightBuilder.h modified in PR(s): Migrate BMixingModule and EcalShapeBase-derived classes to esConsumes #34902
  • File CalibCalorimetry/EcalSRTools/src/EcalDccWeightBuilder.cc modified in PR(s): Migrate BMixingModule and EcalShapeBase-derived classes to esConsumes #34902

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

• CalibCalorimetry/CaloMiscalibTools (alca)
• CalibCalorimetry/EcalLaserAnalyzer (alca)
• CalibCalorimetry/EcalPedestalOffsets (alca)
• CalibCalorimetry/EcalSRTools (alca)
• CalibCalorimetry/EcalTPGTools (l1, alca)
• CalibCalorimetry/EcalTrivialCondModules (alca)

@malbouis, @yuanchao, @cmsbuild, @rekovic, @tlampen, @pohsun, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[tvami]

There is an internal naming inconsistency here as well, right? what was here earlier all started with an underscore, but the new code doesn't and in case of the resdir_ the underscore is in the end. Could this be made uniform in the code? Thanks!

[thomreis]

I agree that this looks rather ugly. The inconsistency in member variable naming scheme has been there before. The initializer list has just made it more apparent. Fixing all these variables will take significant time that I think is better spent migrating more packages to esConsumes.

[tvami]

Hi @thomreis I added some comments regarding the coding style rules, please have a look when you can!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35412c/18145/summary.html
COMMIT: e9138f1
CMSSW: CMSSW_12_1_X_2021-08-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35077/18145/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000324
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test

[qliphy]

please test
ping @cms-sw/l1-l2

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35412c/18509/summary.html
COMMIT: 5ee4bc1
CMSSW: CMSSW_12_1_X_2021-09-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35077/18509/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000967
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

ping @cms-sw/l1-l2

To my understanding, both of them are on vacation (at least that's what I've heard when we collected info for the Offline GT)

[tvami]

@rekovic @cecilecaillol @lathomas would you please sign this?

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1