Finish esConsumes migration for L1TMuonBarrelTrackProducer #35095
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35095/24980
|
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages:
@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a9a0f/18177/summary.html Comparison SummarySummary:
|
|
ping @cms-sw/l1-l2 |
1 similar comment
|
ping @cms-sw/l1-l2 |
| @@ -82,7 +82,7 @@ L1MuBMSEU::~L1MuBMSEU() { | |||
| // | |||
| // run SEU | |||
| // | |||
| void L1MuBMSEU::run(const edm::EventSetup& c) { | |||
| void L1MuBMSEU::run(const L1TMuonBarrelParams& params) { | |||
| if (L1MuBMTFConfig::Debug(3)) | |||
| cout << "Run SEU " << m_ext << " " << m_startTS_Id << endl; | |||
There was a problem hiding this comment.
@Dr15Jones You may take the chance to remove these cout?
There was a problem hiding this comment.
(They are steered by L1MuBMTFConfig::Debug(3): as such they can probably stay, taking also into account that this is not the main topic of this PR...)
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
PR validation:
Code compiles. None of the changes are intended to change behavior.