Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fireworks geometry and proxies #35626

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Oct 12, 2021

PR description:

Improve HGCAL geometry rendering in Fireworks
  • Remove double loop on detIds while selecting HGCAL components. This
    makes the HGCAL geometry rendering much much faster than before.
  • Use the newly introduced parameters/topology information to gather
    information about a specific HGCAL detId. Avoid detId unpacking.
  • Remove ad-hoc magic numbers while offsetting layers in the hadronic
    section.
  • Color coding for the Silicon sensor is now bound to their thickness,
    with the following colour coding:
    • red is 120 um sensor
    • blue is 200 um sensor
    • green is 300 um sensor
Improve Trackster{Layer,Hits} Proxies
  • Position lines (centres of LayerClusters) [and seed lines for the
    Hits Proxy] are now registered to a single TEveStraightLineSet.
    They are, as a consequence, a single entity in the GUI, and the
    selection will highlight them all for each trackster, individually.
  • Edges are now partitioned in two TEveStraightLineSet: non-adjacent
    edges (spans more than one layer) and adjacent edges (between sibling
    layers). Non-adjacent edges are rendered in red, while adjacent edges
    in yellow.
  • Add transparency support for the Layer proxy. Still not fully
    automated, but working.
  • Keep colour memory between consecutive switches between heat map and
    full colour rendering.

* Remove double loop on detIds while selecting HGCAL components. This
  makes the HGCAL geometry rendering much much faster than before.
* Use the newly introduced parameters/topology information to gather
  information about a specific HGCAL detId. Avoid detId unpacking.
* Remove ad-hoc magic numbers while offsetting layers in the hadronic
  section.
* Color coding for the Silicon sensor is now bound to their thickness,
  with the following color coding:
  * red is 120 um sensor
  * blue is 200 um sensor
  * green is 300 um sensor
* Position lines (centres of LayerClusters) [and seed lines for the
  `Hits` Proxy] are now registered to a single `TEveStraightLineSet`.
  They are, as a consequence, a single entity in the GUI, and the
  selection will highlight them all for each trackster, individually.
* Edges are now partitioned in two `TEveStraightLineSet`: non-adjacent
  edges (spans more than one layer) and adjacent edges (between sibling
  layers). Non-adjacent edges are rendered in red, while adjacent edges
  in yellow.
* Add transparency support for the `Layer` proxy. Still not fully
  automated, but working.
* Keep color memory between consecutive switches between `heat map` and
  full color rendering.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35626/25898

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

  • Fireworks/Calo (visualization)
  • Fireworks/Core (visualization)

@cmsbuild, @makortel, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented Oct 12, 2021

@cmsbuild please test

@alja
Copy link
Contributor

alja commented Oct 12, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff3d9d/19571/summary.html
COMMIT: e37b0dd
CMSSW: CMSSW_12_1_X_2021-10-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35626/19571/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2798082
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2798048
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Oct 13, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants