-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve fireworks geometry and proxies #35626
Improve fireworks geometry and proxies #35626
Conversation
* Remove double loop on detIds while selecting HGCAL components. This makes the HGCAL geometry rendering much much faster than before. * Use the newly introduced parameters/topology information to gather information about a specific HGCAL detId. Avoid detId unpacking. * Remove ad-hoc magic numbers while offsetting layers in the hadronic section. * Color coding for the Silicon sensor is now bound to their thickness, with the following color coding: * red is 120 um sensor * blue is 200 um sensor * green is 300 um sensor
* Position lines (centres of LayerClusters) [and seed lines for the `Hits` Proxy] are now registered to a single `TEveStraightLineSet`. They are, as a consequence, a single entity in the GUI, and the selection will highlight them all for each trackster, individually. * Edges are now partitioned in two `TEveStraightLineSet`: non-adjacent edges (spans more than one layer) and adjacent edges (between sibling layers). Non-adjacent edges are rendered in red, while adjacent edges in yellow. * Add transparency support for the `Layer` proxy. Still not fully automated, but working. * Keep color memory between consecutive switches between `heat map` and full color rendering.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35626/25898
|
A new Pull Request was created by @rovere (Marco Rovere) for master. It involves the following packages:
@cmsbuild, @makortel, @Dr15Jones, @alja can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff3d9d/19571/summary.html Comparison SummarySummary:
|
+1 |
PR description:
Improve HGCAL geometry rendering in Fireworks
makes the HGCAL geometry rendering much much faster than before.
information about a specific HGCAL detId. Avoid detId unpacking.
section.
with the following colour coding:
Improve Trackster{Layer,Hits} Proxies
Hits
Proxy] are now registered to a singleTEveStraightLineSet
.They are, as a consequence, a single entity in the GUI, and the
selection will highlight them all for each trackster, individually.
TEveStraightLineSet
: non-adjacentedges (spans more than one layer) and adjacent edges (between sibling
layers). Non-adjacent edges are rendered in red, while adjacent edges
in yellow.
Layer
proxy. Still not fullyautomated, but working.
heat map
andfull colour rendering.