[Online DQM] re-introduce unit tests for visualization

[mmusich]

PR description:

Apparently #35593 has fixed a long-standing issue, leading to not being able to run the visualization unit tests.

PR validation:

Run cmsRun DQM/Integration/python/clients/visualization-live_cfg.py unitTest=True in a recent IB (rebased to HEAD of CMSSW_12_1_X) adding commit 9870cee (proposed in #35639) and it run successfully.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35642/25915

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test with #35639

[jfernan2]

thanks a lot for this PR!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb8d0/19585/summary.html
COMMIT: 446ab2f
CMSSW: CMSSW_12_1_X_2021-10-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35642/19585/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @jfernan2 [DQM] Prompt matrix redefinition  #35605
• @abhih1 Fix out of bounds error in Ecal Validation #35613
• @smuzaffar [GCC11] fix warnings: Change to new method writeOneIOV #35616
• @missirol Undo update of Run-3 GTs in autoCondHLT #35600
• @malbouis [121X] include GTs for Pilot Beam Test #35593
• @CTPPS PPS: use Run3 era in online DQM #35550
• @ggovi Fix for o2o parameters handling from config database #35622
• @rovere Improve fireworks geometry and proxies #35626

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb8d0/19585/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb8d0/19585/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2796791
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2796763
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -369.871 KiB( 39 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -11.641 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3HitsdR03
• DQMHistoSizes: changed ( 1000.0 ): -11.568 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3HitsdR03
• DQMHistoSizes: changed ( 1000.0 ): -11.568 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3HitsdR03
• DQMHistoSizes: changed ( 1000.0 ): -11.352 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByMediumCombinedIsolationDBSumPtCorr3Hits
• DQMHistoSizes: changed ( 1000.0 ): -11.279 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByLooseCombinedIsolationDBSumPtCorr3Hits
• DQMHistoSizes: changed ( 1000.0 ): -11.279 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByTightCombinedIsolationDBSumPtCorr3Hits
• DQMHistoSizes: changed ( 1000.0 ): -11.062 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1DBnewDMwLT
• DQMHistoSizes: changed ( 1000.0 ): -11.062 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByVVTightIsolationMVArun2v1DBoldDMwLT
• DQMHistoSizes: changed ( 1000.0 ): -10.990 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByMediumIsolationMVArun2v1DBnewDMwLT
• DQMHistoSizes: changed ( 1000.0 ): -10.990 KiB RecoTauV/hpsPFTauProducerRealData_hpsPFTauDiscriminationByMediumIsolationMVArun2v1DBoldDMwLT
• DQMHistoSizes: changed ( 1000.0 ): ...
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

please test
(just check if there are no issues in running this standalone, so that we can merge even before #35639)

[mmusich]

@perrotta this PR cannot work (standalone) until the other problem at #35639 is solved.

[mmusich]

hold

[cmsbuild]

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[perrotta]

@perrotta this PR cannot work (standalone) until the other problem at #35639 is solved.

Ok, thank you @mmusich : indeed I lazily demanded the automatic tests to verify it...

[mmusich]

@cmsbuild, please test with #35639

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ddb8d0/19652/summary.html
COMMIT: 446ab2f
CMSSW: CMSSW_12_1_X_2021-10-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35642/19652/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2769241
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2769212
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 170 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[perrotta]

@mmusich #35639 is now merged: do you plan to unhold this one, then?

[mmusich]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1