-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide a reconstruction scenario for the commissioning_run
type introduced in #34832
#35691
provide a reconstruction scenario for the commissioning_run
type introduced in #34832
#35691
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35691/25990
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f9ba3/19679/summary.html Comparison SummarySummary:
|
@mmusich could we have backport to 12_0_X of this one to test it at P5? |
Sorry, ignore my message I realize now you merged them into #35365 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR #34832 introduced DQM runType
commissioning_run
in order to define a new clause in the SiStrip online client to be used when there are no physics triggers.The central DQM team (@LukaLambrecht) showed today at the Joint Operations meeting that a test could be carried out successfully using this new run type, but that was crashing the visualization client for lack of an appropriate reconstruction scenario.
After consultation with @rgerosa we concluded that since the strips tests will be conducted in periods without stable beams, these events can be reconstructed as cosmics.
This PR provides the necessary changes to
DQM/Integration/python/clients/visualization-live_cfg.py
andDQM/Integration/python/clients/visualization-live-secondInstance_cfg.py
PR validation:
At the moment none, it needs more validation online.
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A, but needs to be backported.