Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a reconstruction scenario for the commissioning_run type introduced in #34832 #35691

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 15, 2021

PR description:

PR #34832 introduced DQM runType commissioning_run in order to define a new clause in the SiStrip online client to be used when there are no physics triggers.
The central DQM team (@LukaLambrecht) showed today at the Joint Operations meeting that a test could be carried out successfully using this new run type, but that was crashing the visualization client for lack of an appropriate reconstruction scenario.
After consultation with @rgerosa we concluded that since the strips tests will be conducted in periods without stable beams, these events can be reconstructed as cosmics.
This PR provides the necessary changes to DQM/Integration/python/clients/visualization-live_cfg.py and DQM/Integration/python/clients/visualization-live-secondInstance_cfg.py

PR validation:

At the moment none, it needs more validation online.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A, but needs to be backported.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35691/25990

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2021

I guess it would be nice to test this with #35642, but that's waiting #35639 to be included.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 16, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f9ba3/19679/summary.html
COMMIT: 2d25d78
CMSSW: CMSSW_12_1_X_2021-10-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35691/19679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2751113
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751090
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 170 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

@mmusich could we have backport to 12_0_X of this one to test it at P5?
Thanks!

@jfernan2
Copy link
Contributor

Sorry, ignore my message I realize now you merged them into #35365
Thanks!!

@jfernan2
Copy link
Contributor

+1
Backport tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0275250 into cms-sw:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants