Phase2-hgx295 Change copper cover to SS cover and remove many obsolete files of HGCal geometry

[bsunanda]

PR description:

Change copper cover to SS cover and remove many obsolete files of HGCal geometry. Change of the cover property will affect predictions of 2026D86 workflow, while the cleanups will not affect any existing workflows used in relvals

PR validation:

Checked with all Phase2 scenarios in the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36061/26525

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/data/hgcalCons/v7/hgcalCons.xml modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036
  • File Geometry/HGCalCommonData/data/hgcalCons/v8/hgcalCons.xml modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036
  • File Geometry/HGCalCommonData/python/testHGCV7XML_cfi.py modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036
  • File Geometry/HGCalCommonData/python/testHGCV8XML_cfi.py modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36061/26525/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36061/26525/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[bsunanda]

@cmsbuild Please test

[bsunanda]

@smuzaffar Please check the code check script - the patch it created was grabage

[smuzaffar]

@bsunanda , I think issue is with the merging. there are some conflicts see https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36061/26525/cms-checkout-topic.log

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36061/26528

• This PR adds an extra 40KB to repository

• Found files with invalid states:

  • Geometry/HGCalCommonData/test/python/dumpHGCalModuleDD4Hep_cfg.py:
    • Deleted: 2fa79ed
    • Added: c2b615f
  • Geometry/HGCalCommonData/test/python/dumpHGCalModuleAlgoDD4Hep_cfg.py:
    • Deleted: 2fa79ed
    • Added: c2b615f

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Geometry/HGCalCommonData/data/hgcalCons/v7/hgcalCons.xml modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036
  • File Geometry/HGCalCommonData/data/hgcalCons/v8/hgcalCons.xml modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036
  • File Geometry/HGCalCommonData/python/testHGCV7XML_cfi.py modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036
  • File Geometry/HGCalCommonData/python/testHGCV8XML_cfi.py modified in PR(s): Phase2-hgx294A Add layeroffset attribute to 6-inch wafer geometry files for HGCal #36036

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)
• Geometry/HGCalGeometry (geometry, upgrade)
• Geometry/HGCalSimData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36061/26530

• This PR adds an extra 44KB to repository

• Found files with invalid states:

  • Geometry/HGCalCommonData/test/python/dumpHGCalModuleDD4Hep_cfg.py:
    • Deleted: 2fa79ed
    • Added: c2b615f
  • Geometry/HGCalCommonData/python/testHGCV7XML_cfi.py:
    • Deleted: 2fa79ed
    • Added: c7113c1
  • Geometry/HGCalCommonData/python/testHGCV8XML_cfi.py:
    • Deleted: 2fa79ed
    • Added: c7113c1
  • Geometry/HGCalCommonData/test/python/dumpHGCalModuleAlgoDD4Hep_cfg.py:
    • Deleted: 2fa79ed
    • Added: c2b615f

[cmsbuild]

Pull request #36061 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

[bsunanda]

@cmsbuild please test with #36021

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9be95/20408/summary.html
COMMIT: c7113c1
CMSSW: CMSSW_12_2_X_2021-11-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36061/20408/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3465 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 49345
• DQMHistoTests: Total nulls: 63
• DQMHistoTests: Total successes: 2852460
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[srimanob]

@bsunanda
It is better to describe what is the expected change in the PR description.
From the code and fail comparison,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_2_X_2021-11-09-1100+c9be95/46753/validateJR.html,
I think it is touched only D86. And the cleanup part does not touch anything else.

[bsunanda]

@srimanob I added that in the description of the PR

[srimanob]

+Upgrade

This PR touches only Phase-2 D86, as seen in the test comparison. The cleanup part does not touch anything else. PR tests run fine.
Thanks very much @bsunanda for updating the PR description.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1