Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to root 6.24 #7445

Merged
merged 6 commits into from
Dec 9, 2021
Merged

Move to root 6.24 #7445

merged 6 commits into from
Dec 9, 2021

Conversation

smuzaffar
Copy link
Contributor

This PR should update root 6.24 for default IBs

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_12_2_X/master.

@cmsbuild, @smuzaffar, @iarspider, @ddaina can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Nov 11, 2021

test parameters:

  • full_cmssw = true
  • enable_test = threading

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for slc7_ppc64le_gcc9

@smuzaffar
Copy link
Contributor Author

please test for slc7_aarch64_gcc9

@smuzaffar
Copy link
Contributor Author

please test for cc8_amd64_gcc9

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20454/summary.html
COMMIT: 8c957bb
CMSSW: CMSSW_12_2_X_2021-11-10-2300/slc7_ppc64le_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/20454/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20454/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20454/git-merge-result

Build

I found compilation warning when building: See details on the summary page.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20458/summary.html
COMMIT: 8c957bb
CMSSW: CMSSW_12_2_X_2021-11-10-2300/slc7_aarch64_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/20458/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20458/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20458/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestFWCoreServicesDriver had ERRORS
---> test testFWCoreUtilities had ERRORS

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20453/summary.html
COMMIT: 8c957bb
CMSSW: CMSSW_12_2_X_2021-11-10-2300/slc7_amd64_gcc900
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/20453/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20453/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20453/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 26457 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901845
  • DQMHistoTests: Total failures: 82758
  • DQMHistoTests: Total nulls: 100
  • DQMHistoTests: Total successes: 2818965
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 43.63 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 136.793 ): -0.031 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.874 ): -0.074 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 23234.0,... ): 5.390 KiB MTD/Vertices
  • DQMHistoSizes: changed ( 23234.0,... ): 3.357 KiB MTD/Tracks
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20455/summary.html
COMMIT: 8c957bb
CMSSW: CMSSW_12_2_X_2021-11-10-2300/cc8_amd64_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/20455/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20455/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20455/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 67290 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901845
  • DQMHistoTests: Total failures: 385808
  • DQMHistoTests: Total nulls: 352
  • DQMHistoTests: Total successes: 2515663
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 40.941 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.171 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 136.793 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.874 ): -0.074 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 23234.0,... ): 5.390 KiB MTD/Vertices
  • DQMHistoSizes: changed ( 23234.0,... ): 3.357 KiB MTD/Tracks
  • DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 4.53 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 7.3 ): -2.009 KiB SiStrip/MechanicalView
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: found differences in 14 / 41 workflows

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test for slc7_ppc64le_gcc9

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20489/summary.html
COMMIT: 8c957bb
CMSSW: CMSSW_12_2_X_2021-11-11-2300/slc7_ppc64le_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/20489/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20489/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20489/git-merge-result

Build

I found compilation error when building:

===========================================================


>> Checking EDM Class Version for src/CondFormats/L1TObjects/src/classes_def.xml in libCondFormatsL1TObjects.so
Suggestion: You can run 'scram build updateclassversion' to generate src/CUDADataFormats/BeamSpot/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/slc7_ppc64le_gcc9/edm_checks/libCUDADataFormatsBeamSpot.so] Error 1
@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Version for src/CondFormats/Luminosity/src/classes_def.xml in libCondFormatsLuminosity.so
>> Checking EDM Class Version for src/CondFormats/MFObjects/src/classes_def.xml in libCondFormatsMFObjects.so
@@@@ ----> OK  EDM Class Transients 
@@@@ ----> OK  EDM Class Transients 


@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20485/summary.html
COMMIT: 8c957bb
CMSSW: CMSSW_12_2_X_2021-11-11-2300/slc7_amd64_gcc900
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/20485/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20485/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20485/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2902040
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2902006
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20499/summary.html
COMMIT: 8c957bb
CMSSW: CMSSW_12_2_X_2021-11-11-2300/slc7_ppc64le_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/20499/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20499/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/20499/git-merge-result

Build

I found compilation error when building:

#11 0x000001002d3d9f50 in ?? ()
===========================================================


Suggestion: You can run 'scram build updateclassversion' to generate src/CUDADataFormats/BeamSpot/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/slc7_ppc64le_gcc9/edm_checks/libCUDADataFormatsBeamSpot.so] Error 1
Disabling gnu++: clang has no __float128 support on this target!
@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Version for src/CondFormats/SiPixelObjects/src/classes_def.xml in libCondFormatsSiPixelObjects.so
Disabling gnu++: clang has no __float128 support on this target!
Disabling gnu++: clang has no __float128 support on this target!


@smuzaffar
Copy link
Contributor Author

please test for slc7_ppc64le_gcc9

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Dec 6, 2021

please test for slc7_aarch64_gcc9

@smuzaffar
Copy link
Contributor Author

please test for slc7_amd64_gcc10

@smuzaffar
Copy link
Contributor Author

please test for slc7_amd64_gcc11

@smuzaffar
Copy link
Contributor Author

please test for cc8_amd64_gcc9

@smuzaffar
Copy link
Contributor Author

please test for slc7_ppc64le_gcc9

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/21014/summary.html
COMMIT: 899123c
CMSSW: CMSSW_12_2_X_2021-12-05-2300/slc7_aarch64_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/21014/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testFWCoreUtilities had ERRORS
---> test TestFWCoreServicesDriver had ERRORS
---> test testCondToolsSiStripBuildersReaders had ERRORS

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_12_2_X/master to IB/CMSSW_12_3_X/master December 6, 2021 21:30
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/21019/summary.html
COMMIT: 899123c
CMSSW: CMSSW_12_2_X_2021-12-05-2300/slc7_ppc64le_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/21019/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test_PrepareInputDb had ERRORS
---> test test_MpsWorkFlow had ERRORS
---> test testWriteReadAlCaRecoTriggerBits had ERRORS
---> test testAlignmentOfflineValidation had ERRORS
and more ...

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/21011/summary.html
COMMIT: 899123c
CMSSW: CMSSW_12_2_X_2021-12-01-1100/slc7_amd64_gcc11
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/7445/21011/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/21011/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/21011/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testCondToolsSiStripBuildersReaders had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 31429 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 173802
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 2868129
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 40 files compared)
  • DQMHistoSizes: changed ( 136.874 ): 0.004 KiB MessageLogger/Warnings
  • Checked 173 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

+1

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 58480 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 316037
  • DQMHistoTests: Total nulls: 64
  • DQMHistoTests: Total successes: 2934485
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.17 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.533 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.246 KiB SiStrip/MechanicalView
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: found differences in 13 / 41 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/21012/summary.html
COMMIT: 899123c
CMSSW: CMSSW_12_2_X_2021-12-05-2300/cc8_amd64_gcc9
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/21012/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 61381 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 403829
  • DQMHistoTests: Total nulls: 315
  • DQMHistoTests: Total successes: 2846442
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2.704 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.171 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.117 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 7.3 ): -2.009 KiB SiStrip/MechanicalView
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: found differences in 14 / 41 workflows

@smuzaffar smuzaffar changed the base branch from IB/CMSSW_12_3_X/master to IB/CMSSW_12_3_X/rootnext December 7, 2021 19:02
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2021

Pull request #7445 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/21065/summary.html
COMMIT: 4539e15
CMSSW: CMSSW_12_3_ROOT624_X_2021-12-06-2300/slc7_amd64_gcc900
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/7445/21065/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/21065/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-facf87/21065/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testCondToolsSiStripBuildersReaders had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10241 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250601
  • DQMHistoTests: Total failures: 10465
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3240114
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit eda545a into IB/CMSSW_12_3_X/rootnext Dec 9, 2021
@smuzaffar smuzaffar changed the title [12.2.X] Move to root 6.24 Move to root 6.24 Dec 9, 2021
@makortel
Copy link
Contributor

makortel commented Dec 9, 2021

Just to check if I understood correctly, did this update of 6.24 now build properly on ppc64le?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants