-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read out the CSC cathode shower in TMB/OTMB (HadronicShowerTrigger-9) #36223
Read out the CSC cathode shower in TMB/OTMB (HadronicShowerTrigger-9) #36223
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36223/26834
|
A new Pull Request was created by @dildick (Sven Dildick) for master. It involves the following packages:
@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Can someone run the tests, please? |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ede9b0/20823/summary.html Comparison SummarySummary:
|
@rekovic Can this PR be signed off? Thanks! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@qliphy Can you please sign? Thanks! |
+1 |
PR description:
Read out the CSC cathode shower in TMB/OTMB. Previously the L1T CSC TP emulator read out the anode showers, and the combined showers. This minor update also adds the cathode showers formed in the CLCT logic on the TMB/OTMB.
PR validation:
Code compiles. Tested WF with 11634.0
if this PR is a backport please specify the original PR and why you need to backport that PR:
N.A.
@tahuang1991 @barvic @giovanni-mocellin @Nik-Menendez