Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM] nanoDQMIO change in V0.1 #36331

Merged
merged 1 commit into from
Dec 2, 2021
Merged

[DQM] nanoDQMIO change in V0.1 #36331

merged 1 commit into from
Dec 2, 2021

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Dec 2, 2021

PR description:

Naive change to bring in sincro master version with last minute change from PR #36308

An extra ME for DTs is being added to the nanoDQMIO config file

@perrotta
Copy link
Contributor

perrotta commented Dec 2, 2021

ping bot

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36331/27072

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

  • DQMServices/Core (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Dec 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a2a6e/20928/summary.html
COMMIT: 7b15bb6
CMSSW: CMSSW_12_2_X_2021-12-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36331/20928/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a2a6e/20928/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a2a6e/20928/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 15772 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 22053
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3019880
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor Author

jfernan2 commented Dec 2, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Dec 2, 2021

+1

@cmsbuild cmsbuild merged commit f4b7eec into cms-sw:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants