Updating ECAL Module Class Inheritance

[atishelmanch]

PR description:

The purpose of this PR is to update multiple ECAL modules which inherit from base classes with the previous convention, for example edm::EDAnalyzer, and updating this to either edm::one::EDAnalyzer<>, edm::stream::EDAnalyzer<> or edm::global::EDAnalyzer<> depending on whether modules need to see all events at once, and depending on whether or not they are thread safe: [Reference].

The changes in this PR originally came from cms-AlCaDB/AlCaTools#41. After discovering most modules raised in this issue had already been updated, it was decided to update additional ECAL modules which came up in the most recent static analyzer report, targeting the modules with the error: inherits from edm::EDProducer,edm::EDFilter,edm::EDAnalyzer, or edm::OutputModule.

This should not change any outputs.

PR validation:

Ran code checks and code formats. Also successfully ran a test EDAnalyzer.

cc: @thomreis , @tvami

[tvami]

Since these are not doing anything they can be also removed (maybe for the future... they also dont bother too much)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36317/27055

• This PR adds an extra 172KB to repository

[cmsbuild]

A new Pull Request was created by @atishelmanch (Abraham Tishelman-Charny ) for master.

It involves the following packages:

• CalibCalorimetry/EcalCorrelatedNoiseAnalysisModules (alca)
• CalibCalorimetry/EcalLaserAnalyzer (alca)
• CalibCalorimetry/EcalLaserSorting (alca)
• CalibCalorimetry/EcalPedestalOffsets (alca)
• CalibCalorimetry/EcalTPGTools (l1, alca)
• Calibration/EcalAlCaRecoProducers (alca)
• Calibration/EcalCalibAlgos (alca)
• CondTools/Ecal (db)

@malbouis, @yuanchao, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e15f07/20904/summary.html
COMMIT: c703efd
CMSSW: CMSSW_12_2_X_2021-12-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36317/20904/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3041955
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3041927
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• code change in line w/ PR description
• Jenkins test pass

[tvami]

@perrotta @qliphy this is a fully technical PR, can we please pass the L1T signature?

[perrotta]

+1

• The changes in CalibCalorimetry/EcalTPGTools are minimal and quite technical: I think that the signature from @cms-sw/l1-l2 can be bypassed: please @cms-sw/l1-l2 comment in case you have any complain or proposed furtner modification

[perrotta]

merge