Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECAL - Fix static analyzer issues in CalibCalorimetry/EcalLaserAnalyzer #36371

Merged
merged 1 commit into from
Dec 7, 2021
Merged

ECAL - Fix static analyzer issues in CalibCalorimetry/EcalLaserAnalyzer #36371

merged 1 commit into from
Dec 7, 2021

Conversation

thomreis
Copy link
Contributor

@thomreis thomreis commented Dec 6, 2021

PR description:

This should fix the Static Analyzer issues found in CalibCalorimetry/EcalLaserAnalyzer.

PR validation:

Code compiles.

@cmsbuild cmsbuild added this to the CMSSW_12_2_X milestone Dec 6, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36371/27141

  • This PR adds an extra 92KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

  • CalibCalorimetry/EcalLaserAnalyzer (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Dec 6, 2021

@cmsbuild , please test

tvami
tvami reviewed Dec 6, 2021
View reviewed changes
CalibCalorimetry/EcalLaserAnalyzer/src/ME.cc
@@ -453,7 +453,7 @@ MEChannel* ME::regTree(int ireg) {
leaf_ = leaf_->getDaughter(ieta, iphi, iLMRegion_);
leaf_ = leaf_->getDaughter(ieta, iphi, iLMModule_);
leaf_ = leaf_->getDaughter(ieta, iphi, iSuperCrystal_);
leaf_ = leaf_->getDaughter(ieta, iphi, iCrystal_);
leaf_->getDaughter(ieta, iphi, iCrystal_);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand why line 456 was changed but not l453-455

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDaughter() returns a new MEChannel if it has not been created yet. Since the crystal is the smallest unit it has to stop there and does not branch anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142567/21017/summary.html
COMMIT: cbde0b2
CMSSW: CMSSW_12_2_X_2021-12-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36371/21017/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250586
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Dec 6, 2021

+alca

  • technical PR
  • all tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar modified the milestones: CMSSW_12_2_X, CMSSW_12_3_X Dec 6, 2021
@perrotta
Copy link
Contributor

perrotta commented Dec 7, 2021

+1

  • I think another couple of "easy to fix" static analyzer issues were just forgotten (dead assignment to id1_ and id2_ at lines 614-615 of CalibCalorimetry/EcalLaserAnalyzer/src/MELaserPrim.cc). Besides of that, the remaining part of this technical PR looks correct, and can be merged

@cmsbuild cmsbuild merged commit 6a8849e into cms-sw:master Dec 7, 2021
@thomreis thomreis deleted the ecal-sa-calibcalorimetry-ecallaseranalyzer branch December 8, 2021 11:55
@cmsbuild cmsbuild mentioned this pull request Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvami tvami tvami left review comments

Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_3_X
Development

Successfully merging this pull request may close these issues.
5 participants
@thomreis @cmsbuild @tvami @perrotta @smuzaffar