-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Remove unused PPS materials from Run 3 2021 (replaces #36163) #36307
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36307/27044
|
A new Pull Request was created by @cvuosalo (Carl Vuosalo) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36307/27045
|
Pull request #36307 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again. |
@cmsbuild please test |
@diemort Please check this PR to see if I made the PPS changes correctly. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41c0d6/20894/summary.html Comparison SummarySummary:
|
+1 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@cvuosalo these changes are fine with me. |
Let me check if I'm understanding the plan correctly:
Is that correct? |
@perrotta The big XML files have already been created and uploaded to the DB. See here for details: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4552.html AlCaDB will probably submit the updated GT today or tomorrow. |
+1
|
AlCa PR submitted in #36326 |
The file
Geometry/VeryForwardData/data/CTPPS_Pixel_2021/Modules/v2/ppstrackerMaterials.xml
contains PPS materials that are not used anywhere, as far as I can tell. Some of the composite materials are defined in the wrong order, which could cause problems in the future. It is planned to require that all components of a composite material be defined before the material itself is defined, but we can't make that change as long as there are existing composite materials defined in the wrong order. The PPS materials in this file are the only materials in the Run 3 geometry that are defined in the wrong order. Since they are not even used, it is fairly simple to just remove them.Another unused material
PPS_Epoxy
is deleted from theRP_Materials.xml
file in this PR.After this PR, a new big XML file will be created and uploaded to the DB.
This PR is replaces #36163.
A late addition to this PR is a correction to the ordering of the materials in the
pixbarmaterial.xml
files for the reduced material scenarios. The materials "Polyurethane" and "SupplyTubeEpoxy" were referenced before being defined. The fix is just to move the definitions prior to the references in the file. This fix was made earlier in the mainpixbarmaterial.xml
file but did not get into the reduced material versions of that file until now.PR validation:
The DD4hep XML workflow, 11634.911, was run successfully with this PR.
No backport is needed.