Updated SimProducer for ECAL

[civanch]

PR description:

This PR intended to fix issue #36256. SimProducer used for analysis of hits in ECAL has minor modification. Also InputTag is used instead of string for generatorSmearing label to remove warning in the WF 101.0.

PR validation:

WFs: 101.0, 102.0, 1306.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

no

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36297/27009

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

• Validation/EcalHits (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-244e00/20860/summary.html
COMMIT: 6b18362
CMSSW: CMSSW_12_2_X_2021-11-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36297/20860/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3042214
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3042192
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

test parameters:

• workflows = 101.0, 102.0

[perrotta]

please test

[perrotta]

Uhm, I started the tests with relvals 101.0, 102.0 to test them threaded, but I think that https://github.com/cms-sw/cms-bot/pull/1666/files still prevents it. Let retry with a hack

[perrotta]

please abort

[perrotta]

test parameters:

• workflows = 101.0, 102.0
• pull_request = Update RelValArgs.py: For 12.2 and above run workflow 101, 102 in threadd mode cms-bot#1670
• workflow_threading = 101.0, 102.0
• enable_test = threading

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-244e00/20888/summary.html
COMMIT: 6b18362
CMSSW: CMSSW_12_2_X_2021-11-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36297/20888/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-244e00/102.0_SinglePiE50HCAL+SinglePiE50HCAL

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3042214
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3042186
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[perrotta]

@smuzaffar , I tried to run the tests together with a "dummy" cms-bot PR that reverts cms-sw/cms-bot#1666, with the intention of testing this fix with 101 and 102 run multithread.
I am not sure that it actually succeded: do you know how can I check it?

[smuzaffar]

please test
@perrotta , for PR we run tests in non-threading mode that is why these wf didnot fail. I have updated #36297 (comment) to enable threading tests and added 101,102 to be tested for threaded relvals.

[perrotta]

Thank you @smuzaffar , this is nice to know!

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-244e00/20900/summary.html
COMMIT: 6b18362
CMSSW: CMSSW_12_2_X_2021-11-30-2300/slc7_amd64_gcc900
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36297/20900/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-244e00/102.0_SinglePiE50HCAL+SinglePiE50HCAL

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3041955
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3041933
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[perrotta]

+1

• Threading tests succed also for wf 101 and 102 now