Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEM] GEMAMC13 DataFormats bugfix #36268

Merged
merged 2 commits into from
Dec 4, 2021

Conversation

jshlee
Copy link
Contributor

@jshlee jshlee commented Nov 27, 2021

PR description:

  • in GEMAMC13, orbitNumber() fixed to return uint32_t instead of uint16_t
  • in GEMAMCStatus, orbitNumber comparison between amc13 and amc limited to uint16_t
  • no changes expected.

PR validation:

tested with wf 34611.0, 11611.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36268/26946

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jshlee (Jason Lee) for master.

It involves the following packages:

  • DataFormats/GEMDigi (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@dildick, @rovere, @watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jshlee
Copy link
Contributor Author

jshlee commented Nov 27, 2021

please test

@perrotta
Copy link
Contributor

perrotta commented Dec 2, 2021

please test
(5 days to generate a comparison summary seem too much...)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-746eba/20926/summary.html
COMMIT: cac8881
CMSSW: CMSSW_12_2_X_2021-12-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36268/20926/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 41
  • DQMHistoTests: Total histograms compared: 3041955
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3041933
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
  • Checked 175 log files, 37 edm output root files, 41 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Dec 2, 2021

type bug-fix

@srimanob
Copy link
Contributor

srimanob commented Dec 2, 2021

+Upgrade

Bug fix PR on type of variable. PR test runs fine, and no change is seen (as expected).

@civanch
Copy link
Contributor

civanch commented Dec 3, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Dec 4, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants