CondTools/HLT fix mistake done in #36129

[mmusich]

PR description:

During the modernization of the code done in PR #36129 the endJob method was changed to be an endRun.
This does not reflect how the code was designed originally as the endJob was suppposed to call for the very last time the printMap() method, only once for very last IOV, not treated yet in the previous beginRun(..)s.
The combination of this bug + the unit test introduced in PR #36187 creates an output .twiki file of 1.3GB.... which now is back to 100k.

PR validation:

Run unit tests (scram b runtests)

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36362/27119

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondTools/HLT (hlt, db)

@malbouis, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@silviodonato, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92e5f0/20981/summary.html
COMMIT: 8cb0da3
CMSSW: CMSSW_12_2_X_2021-12-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36362/20981/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3041955
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3041933
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[missirol]

(outputs of the unit test remain unchanged)

[mmusich]

(outputs of the unit test remain unchanged)

Not sure what this is supposed to mean, but that's not correct, neither for the log printout (now all IOVs in which the reader enters are printed) nor for the output twiki file (which is not displayed in the log, but is created nonetheless) whose size is greatly reduced.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36362/27123

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #36362 was updated. @malbouis, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[missirol]

(outputs of the unit test remain unchanged)

This just referred to the corresponding review comments, i.e. the removal of endl in the LogPrint does not change the printouts of the unit test (might be obvious to you, but not to me or others).

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92e5f0/20983/summary.html
COMMIT: 508f9f0
CMSSW: CMSSW_12_2_X_2021-12-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36362/20983/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3041955
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3041933
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[tvami]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1