-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VtxSmearing scenario for Run 3 early data at 13.6 TeV #38616
Conversation
urgent
|
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38616/30900
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@perrotta, @civanch, @mdhildreth, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
No! Unless there are very stringent reasons for it, I would rather avoid having to revert already merged PRs, or branching off from the main release cycle. You can see the currently merged PRs on top of 12_4_1_patch1 in CMSSW_12_4_1_patch1...CMSSW_12_4_X : is there any of those PRs that disturbs you for any reason? |
On Jul 6, 2022, at 4:20 PM, Andrea Perrotta ***@***.***> wrote:
@perrotta @qliphy should we make a release with ONLY this PR on top of 12.4.1?
No! Unless there are very stringent reasons for it, I would rather avoid having to revert already merged PRs, or branching off from the main release cycle.
You can also just make a CMSSW_12_4_1_patchX branch forking off from CMSSW_12_4_1. This was used routinely during run 2 for small fixes (not suggesting this fix or is not a good use case - perhaps not as its for MC and everything being accepted into 12_4_X should be appropriate for that)
David
… You can see the currently merged PRs on top of 12_4_1_patch1 in CMSSW_12_4_1_patch1...CMSSW_12_4_X : is there any of those PRs that disturbs you for any reason?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
+1 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c5610/26013/summary.html Comparison SummarySummary:
|
@cms-sw/orp-l2 we should have this in for the 2300 IB, right? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
@davidlange6 this is exactly what I meant with "branching off from the main release cycle" |
shall we consider updating the vertex smearing in the run-3 relval scenarios too (once the GT has the right reco-level beamspot)?
|
Hi, @mmusich yes, sorry, I meant to reply. We should do that for relvals in 12.5 I think. |
PR description:
This PR adds the realistic vertex smearing scenario for 2022 early data at 13.6 TeV:
Realistic25ns13p6TeVEarly2022Collision
.Parameters used:
PR validation:
Code compiles
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport but a backport to 12_4_X is provided in #38617
FYI @dzuolo @gennai @mmusich @rappoccio @cms-sw/pdmv-l2