modify Run3 PSets for SoftLeptonByMVAComputers instead of individual producers #40485

AnnikaStein · 2023-01-11T20:29:31Z

PR description:

As a follow up for #40464 this PR modifies PSets instead of Producers in RecoBTag/SoftLepton/python/SoftLeptonByMVAComputers_cff.py because all six following producers use the same PSet and can therefore be treated in one go, as discussed in #40464 (comment) @tvami @francescobrivio

PR validation:

Ran basic checks and the particular workflows that were checked in #40464 as well:

scram build code-checks
scram build code-format
scram b -k -j 6 compile COMPILER=iwyu >& a.log
runTheMatrix.py -l 312.0,13234.0 -j9 --ibeos
    -> 2 2 2 1 tests passed, 0 0 0 0 failed

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

…dual producers

cmsbuild · 2023-01-11T20:36:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40485/33665

This PR adds an extra 12KB to repository

cmsbuild · 2023-01-11T20:37:06Z

A new Pull Request was created by @AnnikaStein (Annika Stein) for master.

It involves the following packages:

RecoBTag/SoftLepton (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @JyothsnaKomaragiri, @AnnikaStein, @missirol, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

tvami · 2023-01-11T20:57:32Z

enable nano

tvami · 2023-01-11T20:57:44Z

assign xpog

cmsbuild · 2023-01-11T20:57:51Z

New categories assigned: xpog

@swertz,@vlimant you have been requested to review this Pull request/Issue and eventually sign? Thanks

tvami · 2023-01-11T20:58:05Z

@cmsbuild , please test

tvami · 2023-01-11T20:58:19Z

type btv

cmsbuild · 2023-01-12T04:07:46Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ee7fb/29924/summary.html
COMMIT: 70f8ef3
CMSSW: CMSSW_13_0_X_2023-01-11-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40485/29924/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ee7fb/29924/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ee7fb/29924/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
140.01 step 3
140.03 step 3
140.104 step 3
140.105 step 3
140.106 step 3
140.107 step 3
140.109 step 3
140.111 step 3
140.112 step 3
140.113 step 3
140.114 step 3
140.115 step 3
140.116 step 3
140.11 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

No significant changes to the logs found
Reco comparison results: 2745 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555538
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555510
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10839
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10839
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.240	2.240	0.000 ( +0.0% )	9.57	9.53	+0.4%	1.491	1.515
2500.311	2.330	2.330	0.000 ( +0.0% )	9.23	9.18	+0.5%	1.859	1.882
2500.312	2.284	2.284	0.000 ( +0.0% )	9.36	9.26	+1.0%	1.847	1.885
2500.33	1.101	1.101	0.000 ( +0.0% )	21.95	21.88	+0.3%	1.659	1.754
2500.331	1.396	1.396	0.000 ( +0.0% )	16.07	16.16	-0.6%	1.820	1.789
2500.332	1.328	1.328	0.000 ( +0.0% )	18.03	17.91	+0.7%	1.863	1.766
2500.401	2.161	2.161	0.000 ( +0.0% )	10.36	10.34	+0.1%	1.185	1.198
2500.501	1.726	1.726	0.000 ( +0.0% )	16.64	16.45	+1.1%	1.104	1.115
2500.511	1.134	1.134	0.000 ( +0.0% )	30.77	30.59	+0.6%	1.351	1.367
2500.601	2.073	2.073	0.000 ( +0.0% )	12.30	12.54	-1.9%	1.162	1.190

swertz · 2023-01-12T08:47:36Z

+1

tvami · 2023-01-12T13:08:11Z

@cmsbuild , please test workflow 11634.1

AnnikaStein · 2023-01-13T13:18:29Z

please test workflow 11634.15

Are the tests stuck? This is only 1 wf so it should not take 4 hours (yesterday evening took less than 2h)...

In any case I tested e5d3f2a locally and I get errors due to missing run3_common import (as I suggested in the review).

Sorry for the delay, joined several meetings today and will follow up asap. With the correct imports, it's almost working but still need to modify the custom nano jme which uses a slightly different strategy than the other cffs.

cmsbuild · 2023-01-13T19:06:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40485/33728

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jetsAK4_CHS_cff.py modified in PR(s): Nano: fix array size branch type, support 16 bit ints, use more 8 or 16 bit integers #40478
- File PhysicsTools/NanoAOD/python/jetsAK4_Puppi_cff.py modified in PR(s): Nano: fix array size branch type, support 16 bit ints, use more 8 or 16 bit integers #40478
- File PhysicsTools/NanoAOD/python/jetsAK8_cff.py modified in PR(s): Nano: fix array size branch type, support 16 bit ints, use more 8 or 16 bit integers #40478

cmsbuild · 2023-01-13T19:07:08Z

Pull request #40485 was updated. @cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please check and sign again.

tvami · 2023-01-13T19:21:30Z

@cmsbuild , please test workflow 11634.15

cmsbuild · 2023-01-13T21:45:25Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ee7fb/29988/summary.html
COMMIT: 1ca2ab6
CMSSW: CMSSW_13_0_X_2023-01-13-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40485/29988/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.15

----- Begin Fatal Exception 13-Jan-2023 21:40:35 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'dqmoffline_3_step'
   [2] Prefetching for module NanoAODDQM/'nanoDQMMC'
   [3] Prefetching for module CandMCMatchTableProducer/'boostedTauMCTable'
   [4] Prefetching for module PATObjectCrossLinker/'linkedObjects'
   [5] Prefetching for module PATJetRefSelector/'finalJetsPuppi'
   [6] Prefetching for module PATJetUserDataEmbedder/'updatedJetsPuppiWithUserData'
   [7] Prefetching for module PATJetUpdater/'updatedJetsPuppi'
   [8] Prefetching for module PATJetSelector/'selectedUpdatedPatJetsAK4PFPUPPIFinal'
   [9] Prefetching for module PATJetUpdater/'updatedPatJetsTransientCorrectedAK4PFPUPPIFinal'
   [10] Prefetching for module JetTagProducer/'pfCombinedInclusiveSecondaryVertexV2BJetTagsAK4PFPUPPIFinal'
   [11] Calling method for EventSetup module CandidateCombinedSecondaryVertexESProducer/'candidateCombinedSecondaryVertexV2Computer'
   [12] While getting dependent Record from Record JetTagComputerRecord
Exception Message:
No "BTauGenericMVAJetTagComputerRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

NANO Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10839
DQMHistoTests: Total failures: 26
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10813
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.240	2.240	0.000 ( +0.0% )	9.42	9.50	-0.9%	1.448	1.475
2500.311	2.330	2.330	0.000 ( +0.0% )	9.19	9.16	+0.3%	1.815	1.841
2500.312	2.284	2.284	0.000 ( +0.0% )	9.32	9.29	+0.2%	1.804	1.833
2500.33	1.101	1.101	0.000 ( +0.0% )	21.80	22.03	-1.1%	1.637	1.642
2500.331	1.396	1.396	0.000 ( +0.0% )	16.15	16.06	+0.6%	1.790	1.790
2500.332	1.328	1.328	0.000 ( +0.0% )	17.99	18.09	-0.6%	1.848	1.848
2500.401	2.145	2.161	-0.016 ( -0.7% )	10.35	10.38	-0.4%	1.140	1.162
2500.501	1.716	1.726	-0.011 ( -0.6% )	16.55	16.51	+0.2%	1.069	1.090
2500.511	1.125	1.134	-0.008 ( -0.7% )	30.22	30.26	-0.1%	1.311	1.360
2500.601	2.056	2.073	-0.017 ( -0.8% )	12.12	12.66	-4.3%	1.116	1.145

perrotta · 2023-01-16T08:57:18Z

urgent
(the fix did not succeed yet, but it must be finalized in order to clean up the IBs and build the pre-release; alternatively #40464 will have to get reverted)

missirol · 2023-01-16T11:30:07Z

(the fix did not succeed yet, but it must be finalized in order to clean up the IBs and build the pre-release; alternatively #40464 will have to get reverted)

I think that what would have to be reverted is #40445, and that would not be good.

Given the urgency, the minimal fix for wf 11634.15 is in #40531. (This PR could be kept for future/further improvements.)

tvami · 2023-01-16T13:46:11Z

@cmsbuild , please test with #40531

cmsbuild · 2023-01-16T16:18:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ee7fb/30011/summary.html
COMMIT: 1ca2ab6
CMSSW: CMSSW_13_0_X_2023-01-16-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40485/30011/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.15 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 161 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555538
DQMHistoTests: Total failures: 67
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555449
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10839
DQMHistoTests: Total failures: 26
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10813
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.240	2.240	0.000 ( +0.0% )	9.51	9.55	-0.4%	1.466	1.464
2500.311	2.330	2.330	0.000 ( +0.0% )	9.21	9.14	+0.8%	1.837	1.829
2500.312	2.284	2.284	0.000 ( +0.0% )	9.20	9.25	-0.5%	1.827	1.821
2500.33	1.101	1.101	0.000 ( +0.0% )	22.00	21.91	+0.4%	1.642	1.649
2500.331	1.396	1.396	0.000 ( +0.0% )	16.11	15.95	+1.0%	1.792	1.794
2500.332	1.328	1.328	0.000 ( +0.0% )	18.43	17.88	+3.1%	1.848	1.850
2500.401	2.145	2.161	-0.016 ( -0.7% )	10.56	10.35	+2.0%	1.158	1.153
2500.501	1.716	1.726	-0.011 ( -0.6% )	16.73	16.40	+2.1%	1.079	1.072
2500.511	1.125	1.134	-0.008 ( -0.7% )	30.78	30.17	+2.0%	1.334	1.317
2500.601	2.056	2.073	-0.017 ( -0.8% )	12.60	12.48	+1.0%	1.149	1.128

rappoccio · 2023-01-17T16:34:29Z

As discussed in ORP today, this can be closed since it is superseded by #40539

fix: modify Run3 PSets for SoftLeptonByMVAComputers instead of indivi…

70f8ef3

…dual producers

cmsbuild added this to the CMSSW_13_0_X milestone Jan 11, 2023

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 11, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 11, 2023

cmsbuild added the xpog-pending label Jan 11, 2023

cmsbuild added tests-started and removed tests-pending labels Jan 11, 2023

cmsbuild added the btv label Jan 11, 2023

cmsbuild added tests-approved and removed tests-started labels Jan 12, 2023

cmsbuild added xpog-approved and removed xpog-pending labels Jan 12, 2023

cmsbuild added tests-started and removed tests-approved labels Jan 12, 2023

tvami mentioned this pull request Jan 12, 2023

Update GTs for 2023 #40445

Merged

CSVV2 for run2_nanoAOD_ANY only

1ca2ab6

cmsbuild added code-checks-pending tests-pending and removed tests-started code-checks-approved labels Jan 13, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 13, 2023

cmsbuild added tests-started and removed tests-pending labels Jan 13, 2023

cmsbuild added tests-rejected and removed tests-started labels Jan 13, 2023

cmsbuild added the urgent label Jan 16, 2023

missirol mentioned this pull request Jan 16, 2023

don't run CSVv2 b-tagger in JMECustomNanoAOD for post-LS2 eras #40531

Closed

cmsbuild added requires-external tests-started and removed tests-rejected labels Jan 16, 2023

francescobrivio mentioned this pull request Jan 16, 2023

Fix for wf 11634.15 #40539

Merged

cmsbuild added tests-approved and removed tests-started labels Jan 16, 2023

rappoccio closed this Jan 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modify Run3 PSets for SoftLeptonByMVAComputers instead of individual producers #40485

modify Run3 PSets for SoftLeptonByMVAComputers instead of individual producers #40485

AnnikaStein commented Jan 11, 2023

cmsbuild commented Jan 11, 2023

cmsbuild commented Jan 11, 2023

tvami commented Jan 11, 2023

tvami commented Jan 11, 2023

cmsbuild commented Jan 11, 2023

tvami commented Jan 11, 2023

tvami commented Jan 11, 2023 •

edited

Loading

cmsbuild commented Jan 12, 2023

swertz commented Jan 12, 2023

tvami commented Jan 12, 2023

AnnikaStein commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

tvami commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

perrotta commented Jan 16, 2023

missirol commented Jan 16, 2023

tvami commented Jan 16, 2023

cmsbuild commented Jan 16, 2023

rappoccio commented Jan 17, 2023

modify Run3 PSets for SoftLeptonByMVAComputers instead of individual producers #40485

modify Run3 PSets for SoftLeptonByMVAComputers instead of individual producers #40485

Conversation

AnnikaStein commented Jan 11, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Jan 11, 2023

cmsbuild commented Jan 11, 2023

tvami commented Jan 11, 2023

tvami commented Jan 11, 2023

cmsbuild commented Jan 11, 2023

tvami commented Jan 11, 2023

tvami commented Jan 11, 2023 • edited Loading

cmsbuild commented Jan 12, 2023

Comparison Summary

NANO Comparison Summary

swertz commented Jan 12, 2023

tvami commented Jan 12, 2023

AnnikaStein commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

tvami commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

RelVals

NANO Comparison Summary

perrotta commented Jan 16, 2023

missirol commented Jan 16, 2023

tvami commented Jan 16, 2023

cmsbuild commented Jan 16, 2023

Comparison Summary

NANO Comparison Summary

rappoccio commented Jan 17, 2023

tvami commented Jan 11, 2023 •

edited

Loading