-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GTs for 2023 #40445
Update GTs for 2023 #40445
Conversation
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40445/33597
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
That should be wf |
Thanks Marino! |
test parameters: |
test parameters:
|
@cmsbuild please test I realized the tests hadn't started yet, so I added the |
To run wf
(Obviously, there are also other errors from RelVals and AddOnTests.) |
-1 Failed Tests: RelVals AddOn RelValsValueError: Undefined workflows: 13634.0
Expand to see more relval errors ...AddOn Tests
Expand to see more addon errors ... |
Ok based on the errors I think we still need to add Run3 era modifiers in:
@yuanchao could you take a look at this ~quickly? |
@francescobrivio Yes, for the first two modifications, we can try turn useCondDB off. As to candidateCombinedSecondaryVertexV2Computer, it's the one becomes deprecated in run3. We need to change it to Deep b-taggers. |
Thanks a lot Yuan! I'll give it a try with a PR today! |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
@francescobrivio IBs show an error, so far in wf 11634.15, likely coming from the GTs updated with this PR:
Could you please have a look? |
Yes, seems related to this PR. I'm checking it now! |
Maybe #40485 (comment) will resolve this |
Unfortunately I don't think so. That PR is modifying the softLepton producers, while this error comes from a jet sequence. I'm still trying to figure out exactly where it's colled so I can add the proper modifier for Run3... |
I guess it comes from (all) the lines with "CSVV2" in Btw, #40485 (comment) can be aborted since the failing wf is not |
Given that cross-linking between taus (mentioned for the For FatJets, SubJets there is also https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/jetsAK8_cff.py#L95 and https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/jetsAK8_cff.py#L217 |
hi @AnnikaStein should we have this fixed in the PR40485 ? |
Tests with 11634.15 are currently running in #40485 |
Yes, let me try to add also the proposed changes to NanoAOD tables such that CSVV2 is only included for run2 era modifiers. |
PR description:
This PR updates the GTs for 2023:
126X
version since (AFAIU) this will be the CMSSW release used for the cosmics data-taking (MWGR, CRUZET and CRAFT) in 2023130X
version since (AFAIU) this is the release that will be used for 2023 MCautoCond
+ a cleanup of the old/unused b-tagging tags as detailed in Remove unused b-tagging tags cms-AlCaDB/AlCaTools#58 (this cleanup is now possible since Mask old b-taggers and keep only DNN taggers with Era modifier for run3. #39808, Add Run 3 patjet process with supported b-taggers #40043, Replacing jet b-tagger with 'pfDeepCSVJetTags:probb' for Run 3. #40058, Add Run 3 muon process using proper DNN b-tagger #40100 have been merged, FYI @yuanchao)phase1_2022_realistic_postEE
some deprecated tracking MVA tags (see this CMSTalk post) which were not removed in Remove MVASelector tags for tracking in MC GTs #40010 (since thepostEE
key was not yet included inautoCond
😄)postEE
GT, @cms-sw/pdmv-l2 is there a wf testing it?autoCond
for the 2023 MC GTsphase1_2023_design
,phase1_2023_cosmics
,phase1_2023_cosmics_design
andphase1_2023_realistic_hi
GT differences:
PR validation:
Successfully tested with:
runTheMatrix.py -l 136.731,138.5,138.4,139.001,136.899,12034.0,11634.0,7.23,312.0,12834.0,20834.0 -j10 --ibeos
Backport:
Not a backport.
A backport to 12_6_X with data GTs only will be opened soon.