Add new ALCT-CLCT match algorithm for high pt muon showers #40572

tahuang1991 · 2023-01-20T01:31:02Z

PR description:

Last year we found that current CSC trigger efficiency drops around 5% per station in the inner ring. The root cause is: when high pT muons showered in the CSC chamber, the cathode hits produced by high pT muon is prefired, 1 or 2BX earlier than nominal case, while anode hits are still in-time. Conventional ALCT(built from anode hits)-CLCT(built from cathode hits) match algorithm would be inefficient as CLCTs from high pT muon are also prefired and CLCTs built from secondary hits are more in-time. Therefore we proposed the upgraded ALCT-CLCT match algorithm for muon showers:

define a local zone around the CLCT key halfstrip to flag the local shower if total hits in the local zone is over threshold
if local shower is valid, then ALCT-CLCT match would pick up earlier CLCT, rather than in-time CLCT. if local shower is not found, then it rolls back to conventional ALCT-CLCT match: ALCT would pick up more in-time CLCT, namely CLCT in the center of match window
local shower definition is configurable: both the shower zone and shower threshold. Right now local shower feature is not enabled in the default configuration
it is NOT included in firmware yet but MC studies with TeV muons showed that new ALCT-CLCT match would improve trigger efficiency when muon showers in the CSC station.

PR validation:

presentation on CSC meeting:
https://indico.cern.ch/event/1197553/contributions/5035258/attachments/2504761/4304563/TaoOTMBStatus_TAMU_20220907_EMTFEff.pdf
https://indico.cern.ch/event/1199888/contributions/5047438/attachments/2508640/4311202/TaoOTMBStatus_TAMU_20220907_EMTFEfffollowup.pdf

presentation on L1 DPG meeting: slide16-19
https://indico.cern.ch/event/1216605/contributions/5117665/attachments/2538591/4369875/Tao_OTMB_L1TDPG_20221031.pdf

1.add CLCT sorting by qual+bending for ALCT-CLCT match 2.add local shower check and switch to new CLCT sorting when sorting by Bx is off and there is at least one local shower around CLCT in the first half of match window

cmsbuild · 2023-01-20T01:42:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40572/33815

This PR adds an extra 64KB to repository

cmsbuild · 2023-01-20T01:43:20Z

A new Pull Request was created by @tahuang1991 (TaoHuang) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@giovanni-mocellin, @JanFSchulte, @eyigitba, @Martin-Grunewald, @missirol, @ptcox, @valuev this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

perrotta · 2023-01-20T10:03:14Z

please test

cmsbuild · 2023-01-20T12:54:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6677d5/30091/summary.html
COMMIT: 3fac2a3
CMSSW: CMSSW_13_0_X_2023-01-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40572/30091/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555479
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555451
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

tahuang1991 · 2023-01-24T23:40:00Z

any comments before merging this PR to cmssw?

cecilecaillol · 2023-01-25T08:08:31Z

+l1

cmsbuild · 2023-01-25T08:08:54Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

eyigitba · 2023-01-25T09:01:49Z

Hi @tahuang1991 , do I understand correctly that sortClctBx is set to True for now and will be changed when the firmware is also updated?

perrotta · 2023-01-25T09:18:56Z

L1Trigger/CSCTriggerPrimitives/python/params/tmbParams.py

@@ -49,6 +51,8 @@
 tmbPhase2 = tmbPhase1.clone(
    # ALCT-CLCT stays at 7 for the moment
    matchTrigWindowSize = 7,
+    #use CLCT sorted by Bx only for ALCT-CLCTmatch for now
+    sortClctBx = cms.bool(True),


Suggested change

sortClctBx = cms.bool(True),

sortClctBx = True,

perrotta · 2023-01-25T09:24:59Z

L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc

+    if (totalHits >= localShowerThresh)
+      localShowerFlag[bx] = true;
+    else
+      localShowerFlag[bx] = false;


Suggested change

if (totalHits >= localShowerThresh)

localShowerFlag[bx] = true;

else

localShowerFlag[bx] = false;

localShowerFlag[bx] = totalHits >= localShowerThresh;

perrotta · 2023-01-25T09:45:12Z

L1Trigger/CSCTriggerPrimitives/interface/CSCCathodeLCTProcessor.h

+  void checkLocalShower(
+      int zone, const std::vector<int> strip[CSCConstants::NUM_LAYERS][CSCConstants::MAX_NUM_HALF_STRIPS_RUN2_TRIGGER]);


It is cheaper to pass the vector by reference:

Suggested change

void checkLocalShower(

int zone, const std::vector<int> strip[CSCConstants::NUM_LAYERS][CSCConstants::MAX_NUM_HALF_STRIPS_RUN2_TRIGGER]);

void checkLocalShower(

int zone, const std::vector<int>& strip[CSCConstants::NUM_LAYERS][CSCConstants::MAX_NUM_HALF_STRIPS_RUN2_TRIGGER]);

(there are other such cases in the rest of the code...)

okay. I will improve the code with your above three suggestions. Thanks.

i tried to switch to vector reference in checkLocalShower, but since this vector is used in pulseExtension, the compiling failed... Multiple places in ths CSC trigger emulator used the vector rather reference as argument. I think it is better to do a individual commit to improve this.

tahuang1991 · 2023-01-25T14:48:15Z

yes

cmsbuild · 2023-01-25T17:38:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40572/33882

This PR adds an extra 32KB to repository

cmsbuild · 2023-01-25T17:38:42Z

Pull request #40572 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

perrotta · 2023-01-26T21:48:26Z

please test

cmsbuild · 2023-01-27T00:09:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6677d5/30199/summary.html
COMMIT: d6a1755
CMSSW: CMSSW_13_0_X_2023-01-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40572/30199/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555470
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

cecilecaillol · 2023-01-27T09:18:52Z

+l1

cmsbuild · 2023-01-27T09:19:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-01-27T11:54:18Z

+1

tahuang1991 added 2 commits October 1, 2022 01:11

New CLCT sorting for ALCT-CLCT match

74c319c

1.add CLCT sorting by qual+bending for ALCT-CLCT match 2.add local shower check and switch to new CLCT sorting when sorting by Bx is off and there is at least one local shower around CLCT in the first half of match window

code format change

3fac2a3

cmsbuild added this to the CMSSW_13_0_X milestone Jan 20, 2023

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Jan 20, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 20, 2023

cmsbuild added tests-started and removed tests-pending labels Jan 20, 2023

cmsbuild added tests-approved and removed tests-started labels Jan 20, 2023

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jan 25, 2023

perrotta reviewed Jan 25, 2023

View reviewed changes

minor changes to improve the coding

d6a1755

cmsbuild removed the l1-approved label Jan 25, 2023

cmsbuild added code-checks-pending l1-pending pending-signatures tests-pending and removed tests-approved code-checks-approved labels Jan 25, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 25, 2023

cmsbuild added tests-started and removed tests-pending labels Jan 26, 2023

cmsbuild mentioned this pull request Jan 26, 2023

Backport codes for adding new data catalogs from Rucio storage description (RucioCatalog) and use it by default instead of trivial data catalogs (TrivialCatalog) #37278, and related bug fixes #40628

Closed

cmsbuild added tests-approved and removed tests-started labels Jan 27, 2023

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Jan 27, 2023

cmsbuild added orp-approved and removed orp-pending labels Jan 27, 2023

cmsbuild merged commit ae444b6 into cms-sw:master Jan 27, 2023

This was referenced Jan 27, 2023

[ROOT626] Updated root to tip of branch v6-26-00-patches cms-sw/cmsdist#8267

Merged

[BuildRules] First implementation of RocM build rules cms-sw/cmsdist#8268

Merged

[ROOT626] Updated root to tip of branch v6-26-00-patches cms-sw/cmsdist#8277

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new ALCT-CLCT match algorithm for high pt muon showers #40572

Add new ALCT-CLCT match algorithm for high pt muon showers #40572

tahuang1991 commented Jan 20, 2023 •

edited

Loading

cmsbuild commented Jan 20, 2023

cmsbuild commented Jan 20, 2023

perrotta commented Jan 20, 2023

cmsbuild commented Jan 20, 2023

tahuang1991 commented Jan 24, 2023

cecilecaillol commented Jan 25, 2023

cmsbuild commented Jan 25, 2023

eyigitba commented Jan 25, 2023

perrotta Jan 25, 2023

perrotta Jan 25, 2023

perrotta Jan 25, 2023 •

edited

Loading

tahuang1991 Jan 25, 2023

tahuang1991 Jan 25, 2023

tahuang1991 commented Jan 25, 2023

cmsbuild commented Jan 25, 2023

cmsbuild commented Jan 25, 2023

perrotta commented Jan 26, 2023

cmsbuild commented Jan 27, 2023

cecilecaillol commented Jan 27, 2023

cmsbuild commented Jan 27, 2023

perrotta commented Jan 27, 2023

		void checkLocalShower(
		int zone, const std::vector<int> strip[CSCConstants::NUM_LAYERS][CSCConstants::MAX_NUM_HALF_STRIPS_RUN2_TRIGGER]);

Add new ALCT-CLCT match algorithm for high pt muon showers #40572

Add new ALCT-CLCT match algorithm for high pt muon showers #40572

Conversation

tahuang1991 commented Jan 20, 2023 • edited Loading

PR description:

PR validation:

cmsbuild commented Jan 20, 2023

cmsbuild commented Jan 20, 2023

perrotta commented Jan 20, 2023

cmsbuild commented Jan 20, 2023

Comparison Summary

tahuang1991 commented Jan 24, 2023

cecilecaillol commented Jan 25, 2023

cmsbuild commented Jan 25, 2023

eyigitba commented Jan 25, 2023

perrotta Jan 25, 2023

Choose a reason for hiding this comment

perrotta Jan 25, 2023

Choose a reason for hiding this comment

perrotta Jan 25, 2023 • edited Loading

Choose a reason for hiding this comment

tahuang1991 Jan 25, 2023

Choose a reason for hiding this comment

tahuang1991 Jan 25, 2023

Choose a reason for hiding this comment

tahuang1991 commented Jan 25, 2023

cmsbuild commented Jan 25, 2023

cmsbuild commented Jan 25, 2023

perrotta commented Jan 26, 2023

cmsbuild commented Jan 27, 2023

Comparison Summary

cecilecaillol commented Jan 27, 2023

cmsbuild commented Jan 27, 2023

perrotta commented Jan 27, 2023

tahuang1991 commented Jan 20, 2023 •

edited

Loading

perrotta Jan 25, 2023 •

edited

Loading