Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a simple vector add test with alpaka #40580

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Implement a simple vector add test with alpaka #40580

merged 2 commits into from
Jan 23, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 20, 2023 •
edited
Loading

PR description:

Implement a simple vector add test with alpaka and cms::alpakatools utilities.

PR validation:

The new tests pass.

@fwyzard fwyzard changed the title Implement simple vector add test with alpaka and cms:alpakatools Implement simple vector add test with alpaka Jan 20, 2023
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Jan 20, 2023
@fwyzard fwyzard changed the title Implement simple vector add test with alpaka Implement a simple vector add test with alpaka Jan 20, 2023
@fwyzard fwyzard force-pushed the add_alpaka_kernel_tests branch from 9ccd4a7 to 6c8710c Compare January 20, 2023 15:55
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 20, 2023

hold

@cmsbuild cmsbuild added the hold label Jan 20, 2023
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 20, 2023

In addition to adding the test, this PR is going to be used to exemplify two problems in the SCRAM build rules:

  • the *.dev.cc files are compiled with nvcc even when building the CPU version of the tests
  • SCRAM does not actually run the alpaka tests when invoked as scram b runtests

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40580/33830

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 20, 2023

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 20, 2023

please test

This was referenced Jan 20, 2023
Closed
Closed
@fwyzard fwyzard force-pushed the add_alpaka_kernel_tests branch from 6c8710c to 4eccb8e Compare January 20, 2023 16:29
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 20, 2023

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 20, 2023

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40580/33832

  • This PR adds an extra 12KB to repository

@fwyzard
Fix 1-dimensional strided loops
9109584
@fwyzard
Implement a simple vector add test with alpaka
60f46a9 
Implement a 1-dimensional vector add test with alpaka and cms::alpakatools utilities.
@fwyzard fwyzard force-pushed the add_alpaka_kernel_tests branch from e51d4af to 60f46a9 Compare January 22, 2023 11:44
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40580/33839

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40580 was updated. @cmsbuild, @makortel, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 22, 2023

please test with cms-sw/cmsdist#8256

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c00b54/30114/summary.html
COMMIT: 60f46a9
CMSSW: CMSSW_13_0_X_2023-01-21-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40580/30114/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c00b54/30114/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c00b54/30114/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1568 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555479
  • DQMHistoTests: Total failures: 9351
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3546106
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 263
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19599
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

unhold

@cmsbuild cmsbuild removed the hold label Jan 23, 2023
@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

OK, the test infrastructure now works, and the simple test works as well.
While I'm looking to add a N-dimensional test, these changes could already go in as they are.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 23, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 976aa1f into cms-sw:master Jan 23, 2023
@fwyzard fwyzard mentioned this pull request Jan 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved fully-signed heterogeneous-approved orp-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@fwyzard @cmsbuild @smuzaffar @perrotta