-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix N-dimensional strided loops and extend the alpaka tests #40598
Conversation
enable gpu |
please test |
This PR continue the work done in #40580, adding more tests for N-dimensional loops. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40598/33852
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
please test |
+heterogeneous |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40598/33853
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Implement an N-dimensional vector add test with alpaka and cms::alpakatools utilities.
848d218
to
4eaaf65
Compare
please test |
+heterogeneous |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40598/33854
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5ef8e/30135/summary.html Comparison SummarySummary:
GPU Comparison SummarySummary:
|
+1 |
PR description:
Implement an N-dimensional vector add test with alpaka and
cms::alpakatools
utilities.Refactor the checks for accelerators that support multiple threads per block (e.g. GPUs) or a single thread with multiple elements (e.g. serial CPUs), and use the new constant to simplify the workdiv generation and the strided loops.
PR validation:
The new unit tests pass.