Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex163 Try to address the issue of RPC geometry #41907

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jun 9, 2023

PR description:

Try to address the issue of RPC geometry. Address the difference between DDD and DD4hep versions

PR validation:

Use the runTheMatrix methods

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41907/35857

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41907/35858

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/RPCGeometryBuilder (geometry)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 9, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b3aa/33060/summary.html
COMMIT: c573af3
CMSSW: CMSSW_13_2_X_2023-06-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41907/33060/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219887
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jun 9, 2023

+1

I hope that significant increase of LogVerbatim statements will not affect overall performance. Let us left thing as they are.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4e71041 into cms-sw:master Jun 9, 2023
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Jun 18, 2023
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Jun 18, 2023
cmsbuild added a commit that referenced this pull request Jun 20, 2023
Run3-gex164B Fix the bug in the RPC geometry - backport of the PRs #41907, #41921, #41990 from 13_2_X to 13_0_X
cmsbuild added a commit that referenced this pull request Jun 20, 2023
Run3-gex164A Fix the bug in rpc geometry - backport of the PR's #41907, #41921, #41990 from 13_2_X to 13_1_X
jsamudio pushed a commit to jsamudio/cmssw that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants