Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex164 Try to address the issue of RPC geometry for Run3 applications #41921

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

bsunanda
Copy link
Contributor

PR description:

Try to address the issue of RPC geometry for Run3 applications. To be tested by muon group before committing the changes to a new payload

PR validation:

An overlap check is performed for the new XML file

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41921/35879

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Geometry/MuonCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@ptcox, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d418c9/33085/summary.html
COMMIT: ad598a6
CMSSW: CMSSW_13_2_X_2023-06-11-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41921/33085/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 20 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3220833
  • DQMHistoTests: Total failures: 2228
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3218583
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jun 11, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor

civanch commented Jun 11, 2023

regression is connected with MKFit not related to this PR.

@perrotta
Copy link
Contributor

+1

  • It adds a new configuration to be tested by muon group: it does not affect current workflows

@mileva
Copy link
Contributor

mileva commented Jun 15, 2023

To ping the relevant people @mileva @bapavlov @slomeo @jhgoh

bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Jun 18, 2023
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request Jun 18, 2023
cmsbuild added a commit that referenced this pull request Jun 20, 2023
Run3-gex164B Fix the bug in the RPC geometry - backport of the PRs #41907, #41921, #41990 from 13_2_X to 13_0_X
cmsbuild added a commit that referenced this pull request Jun 20, 2023
Run3-gex164A Fix the bug in rpc geometry - backport of the PR's #41907, #41921, #41990 from 13_2_X to 13_1_X
jsamudio pushed a commit to jsamudio/cmssw that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants