-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add specialized ZeroBias relval steps and use them for 2022 and 2023 data workflows, in order to employ @rerecoZeroBias
DQM sequence
#42031
Conversation
…nd use them for 2022 and 2023 data workflows, in order to employ the @rerecoZeroBias DQM sequence
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42031/36003
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1393bb/33282/summary.html Comparison SummarySummary:
|
I suspect that we may need to backport. @cms-sw/ppd-l2 |
it cannot be a verbatim backport, because the 2023 data workflows aren't there in CMSSW_13_0_X: cmssw/Configuration/PyReleaseValidation/python/relval_steps.py Lines 566 to 569 in 60cfb53
unless we backport also #41629 |
+Upgrade |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title says it all. It was recently re-discovered that in the 2022 and 2023 data workflows since the
@standardDQM*
sequence is run also in theZeroBias
PDs there is no dedicated trigger bits filtering in the Tracker and Tracking sequences, leading (among other things) to have plots of track multiplicity in which there are events with no tracks, see for example:coming from the recent 2023Bvs2023C PdmV campaign.
In this PR I correct the situation by specializing the ZeroBias workflows to run a DQM sequence which contains the
@rerecoZeroBias*
instead in the first and harvesting DQM step.This would help using ZeroBias consistently in the future data release validations.
PR validation:
none.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, to be partially backported.