Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition of 2023C WFs and modifications 2023B WFs to run with era Run3 #42069

Merged
merged 6 commits into from
Jun 26, 2023

Conversation

sunilUIET
Copy link
Contributor

@sunilUIET sunilUIET commented Jun 23, 2023

This PR is to add WFs for 2023C and modify 2023B WFs to use era Run3 (in place of era Run3_2023). While implementation, #42031 is taken into account to add rerecoZeroBias DQM for ZeroBias PD.
This PR new WFs 141.031-141.038

Once merged in the master, these changes will be backported to 13_0_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42069/36050

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sunilUIET (sunil bansal) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@cmsbuild, @bbilin, @srimanob, @sunilUIET, @AdrianoDee can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@sunilUIET
Copy link
Contributor Author

Hi @mmusich

I had to make some changes for 2023B WFs which conflicted with your PR #42031

Please have a look.

@sunilUIET
Copy link
Contributor Author

test parameters:

relvals_opt= -w standard
workflows = 141.001,141.002,141.003,141.004,141.005,141.006,141.007,141.008,141.009,141.010,141.011,141.012,141.013,141.031,141.032,141.033,141.034,141.035,141.036,141.037,141.038

@mmusich
Copy link
Contributor

mmusich commented Jun 23, 2023

@sunilUIET

I had to make some changes for 2023B WFs which conflicted with your PR #42031

I don't see conflicts.

@sunilUIET
Copy link
Contributor Author

@sunilUIET

I had to make some changes for 2023B WFs which conflicted with your PR #42031

I don't see conflicts.

Yes, I fixed it now.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42069/36051

@mmusich
Copy link
Contributor

mmusich commented Jun 23, 2023

Yes, I fixed it now.

so, I am not sure what I should comment about. I guess we should coordinate for the backports instead.

@cmsbuild
Copy link
Contributor

Pull request #42069 was updated. @cmsbuild, @bbilin, @srimanob, @sunilUIET, @AdrianoDee can you please check and sign again.

@sunilUIET
Copy link
Contributor Author

please test

@sunilUIET
Copy link
Contributor Author

Yes, I fixed it now.

so, I am not sure what I should comment about. I guess we should coordinate for the backports instead.

Yes, as we discussed, I will take care of backporting these changes keeping in mind the changes coming along with backports of #42069

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31699f/33363/summary.html
COMMIT: 0dbcea6
CMSSW: CMSSW_13_2_X_2023-06-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42069/33363/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31699f/33363/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31699f/33363/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 2722960
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2722935
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 182 log files, 138 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@sunilUIET
Copy link
Contributor Author

test parameters:

relvals_opt= -w standard
workflows = 141.001,141.002,141.003,141.004,141.005,141.006,141.007,141.008,141.009,141.010,141.011,141.012,141.013,141.031,141.032,141.033,141.034,141.035,141.036,141.037,141.038

@sunilUIET
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42069/36065

@cmsbuild
Copy link
Contributor

Pull request #42069 was updated. @bbilin, @srimanob, @sunilUIET, @AdrianoDee can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31699f/33379/summary.html
COMMIT: ba9fc60
CMSSW: CMSSW_13_2_X_2023-06-25-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42069/33379/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31699f/33379/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31699f/33379/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3200270
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3200242
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@sunilUIET
Copy link
Contributor Author

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants