-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce PCL-like workflows for SiStrip Lorentz Angle Monitoring (and potentially calibration) #42574
Introduce PCL-like workflows for SiStrip Lorentz Angle Monitoring (and potentially calibration) #42574
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42574/36589
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@perrotta, @rappoccio, @bbilin, @consuegs, @tvami, @cmsbuild, @AdrianoDee, @miquork, @saumyaphor4252, @srimanob, @sunilUIET, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild, please test |
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
40e8a63
to
ca40f6c
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42574/36591
|
Pull request #42574 was updated. @perrotta, @rappoccio, @bbilin, @consuegs, @tvami, @cmsbuild, @AdrianoDee, @miquork, @saumyaphor4252, @srimanob, @sunilUIET, @francescobrivio, @fabiocos, @davidlange6 can you please check and sign again. |
+alca
|
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 do you have comments? |
+pdmv |
+Upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR introduces a PCL-like workflow for SiStrip Lorentz Angle Monitoring (and potentially calibration), by using the
SiStripCalCosmics
dataset in input. The setup closesly resemble the one presented multiple times (see e.g. this talk) in which the hall mobility of the strips modules (only TIB and TOB for the time being, grouped in regions sharing same layer / module type) is estimated by fitting the distribution of the Strip cluster multiplicity as a function of the track grazing angle.The
SiStripCalCosmics
AlCaReco producer is added to theExpressCosmics
PD inautoAlCa
while the newPromptCalibProdSiStripLA
ALCAPrompt producer is introduced in several configuration files inConfiguration/StandardSequences
package.PR validation:
Run the following command:
followed by:
and obtained reasonable output DQM and db files.
Also run successfully the augmented relval wf 1005.0 (
runTheMatrix.py -l 1005.0 -t 4 -j 8 --ibeos
.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, might be backported to 13.2.X for testing purposes during the 2023 HI data-taking