Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PCL-like workflows for SiStrip Lorentz Angle Monitoring (and potentially calibration) #42574

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 15, 2023

PR description:

This PR introduces a PCL-like workflow for SiStrip Lorentz Angle Monitoring (and potentially calibration), by using the SiStripCalCosmics dataset in input. The setup closesly resemble the one presented multiple times (see e.g. this talk) in which the hall mobility of the strips modules (only TIB and TOB for the time being, grouped in regions sharing same layer / module type) is estimated by fitting the distribution of the Strip cluster multiplicity as a function of the track grazing angle.
The SiStripCalCosmics AlCaReco producer is added to the ExpressCosmics PD in autoAlCa while the new PromptCalibProdSiStripLA ALCAPrompt producer is introduced in several configuration files in Configuration/StandardSequences package.

PR validation:

Run the following command:

cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiStripLA --conditions 130X_dataRun3_Prompt_v2 --scenario cosmics --data --era Run3_2023 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100000 --dasquery='file dataset=/Cosmics/Commissioning2023-SiStripCalCosmics-PromptReco-v1/ALCARECO run=364141' --nThreads=4 

followed by:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripLA --conditions 130X_dataRun3_Prompt_v2 --scenario pp --data --era Run3_2023 -n -1 --filein file:PromptCalibProdSiStripLA.root

and obtained reasonable output DQM and db files.
Also run successfully the augmented relval wf 1005.0 (runTheMatrix.py -l 1005.0 -t 4 -j 8 --ibeos.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported to 13.2.X for testing purposes during the 2023 HI data-taking

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42574/36589

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibTracker/SiStripLorentzAngle (alca)
  • Calibration/TkAlCaRecoProducers (alca)
  • Configuration/AlCa (alca)
  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @bbilin, @consuegs, @tvami, @cmsbuild, @AdrianoDee, @miquork, @saumyaphor4252, @srimanob, @sunilUIET, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@echabert, @VourMa, @felicepantaleo, @robervalwalsh, @argiro, @Martin-Grunewald, @thomreis, @threus, @slomeo, @makortel, @JanFSchulte, @dgulhan, @missirol, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @fabiocos, @rchatter, @gbenelli, @wang0jin, @sameasy this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 15, 2023

test parameters:

  • workflow = 1005.0

@mmusich
Copy link
Contributor Author

mmusich commented Aug 15, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1bd0b/34293/summary.html
COMMIT: 40e8a63
CMSSW: CMSSW_13_3_X_2023-08-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42574/34293/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42574/36591

@cmsbuild
Copy link
Contributor

Pull request #42574 was updated. @perrotta, @rappoccio, @bbilin, @consuegs, @tvami, @cmsbuild, @AdrianoDee, @miquork, @saumyaphor4252, @srimanob, @sunilUIET, @francescobrivio, @fabiocos, @davidlange6 can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Aug 16, 2023

+alca

  • tests pass, diffs in MsgLogger only
  • code in line with the PR desc

@mmusich
Copy link
Contributor Author

mmusich commented Aug 22, 2023

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 do you have comments?

@sunilUIET
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 86e051b into cms-sw:master Aug 22, 2023
@mmusich mmusich deleted the dev_SiStripLorentzAngleMonitor_13_3_X branch August 30, 2023 09:52
@mmusich mmusich restored the dev_SiStripLorentzAngleMonitor_13_3_X branch August 30, 2023 09:52
@mmusich mmusich deleted the dev_SiStripLorentzAngleMonitor_13_3_X branch August 30, 2023 09:53
@mmusich mmusich restored the dev_SiStripLorentzAngleMonitor_13_3_X branch August 30, 2023 09:53
@mmusich mmusich deleted the dev_SiStripLorentzAngleMonitor_13_3_X branch August 30, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants