HGCAL Electronics mapping

[kerstinlovisa]

type hgcal
assign hgcal-dpg

PR description:

Adding the infrastructure needed to

• provide the electronics to detector identifier mapping
• provide the dense indexer for unpacked data and conditions (made available through EventSetup)
• provide detailed information on the cell and modules (made available through EventSetup in SoAs)

The tool has been discussed in the HGCAL DPG (see
https://indico.cern.ch/event/1358621/#8-progress-with-the-logical-ma and provisional documentation in https://docs.google.com/document/d/1kGKsMBQ8CWC7kJN71aJmsUv4vVDJ8ZlG_D1ColCEuAk/edit#bookmark=id.8ys9dfg99vqv)

The 3 additional records has been discussed in the AlCaDB (see https://indico.cern.ch/event/1372780/#11-hgcal-electrons-mapping-for)

PR validation:

This PR is not expected to impact any workflow thus we expect 100% success in the tests. The PR is however accompanied by a series of unit tests and analyzers (under the test) sub-directories. They have been used to validate the content produced by the new pieces of code being added to the repository.

@pfs @jalimena

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43751/38465

• This PR adds an extra 156KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43751/38465/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43751/38465/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43751/38467

• This PR adds an extra 160KB to repository

[cmsbuild]

A new Pull Request was created by @kerstinlovisa (Lovisa Rygaard) for master.

It involves the following packages:

• CondFormats/DataRecord (db, alca)
• CondFormats/HGCalObjects (db, upgrade, alca)
• DataFormats/HGCalDigi (simulation, upgrade)
• Geometry/HGCalMapping (****)

The following packages do not have a category, yet:

Geometry/HGCalMapping
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@subirsarkar, @perrotta, @civanch, @srimanob, @mdhildreth, @francescobrivio, @consuegs, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks.
@bsunanda, @PonIlya, @fabiocos, @seemasharmafnal, @mmusich, @rovere, @yuanchao, @missirol, @tocheng, @rsreds this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af2dd2/36945/summary.html
COMMIT: 48bee4b
CMSSW: CMSSW_14_0_X_2024-01-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43751/36945/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-19-1100/src/EventFilter/HGCalRawToDigi/src/HGCalRawDataPackingTools.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-19-1100/src/EventFilter/HGCalRawToDigi/src/HGCalUnpacker.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-19-1100/src/EventFilter/HGCalRawToDigi/src/TrivialEmulator.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-19-1100/src/EventFilter/HGCalRawToDigi/src/HGCalUnpacker.cc: In instantiation of 'void HGCalUnpacker::parseSLink(const std::vector&, const std::function&, const std::function&) [with D = HGCalElectronicsId]':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-19-1100/src/EventFilter/HGCalRawToDigi/src/HGCalUnpacker.cc:708:16:   required from here
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-19-1100/src/EventFilter/HGCalRawToDigi/src/HGCalUnpacker.cc:155:40: error: no matching function for call to 'HGCalElectronicsId::HGCalElectronicsId(uint16_t&, uint8_t&, uint8_t&, uint8_t&, uint8_t&)'
  155 |               const HGCalElectronicsId id(sLink, captureBlock, econd, erx, channel);
      |                                        ^~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-19-1100/src/EventFilter/HGCalRawToDigi/interface/HGCalUnpacker.h:15,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-19-1100/src/EventFilter/HGCalRawToDigi/src/HGCalUnpacker.cc:11:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2024-01-19-1100/src/DataFormats/HGCalDigi/interface/HGCalElectronicsId.h:47:3: note: candidate: 'HGCalElectronicsId::HGCalElectronicsId(const HGCalElectronicsId&)'


[pfs]

please test

[jfernan2]

+1

[pfs]

Hello, anything missing? Could we get the missing signatures? For hgcal i can try and abuse of my DPG role unless @cseez or @felicepantaleo want to chime in...

[perrotta]

Hello, anything missing? Could we get the missing signatures? For hgcal i can try and abuse of my DPG role unless @cseez or @felicepantaleo want to chime in...

@cms-sw/geometry-l2 @cms-sw/simulation-l2 @cms-sw/hgcal-dpg-l2 @cms-sw/upgrade-l2

[pfs]

+1

[civanch]

+1

[antoniovilela]

ping @cms-sw/upgrade-l2

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/Geometry-HGCalMapping#1

[antoniovilela]

cms-data/Geometry-HGCalMapping#1 is now merged.
cmsdist PR: cms-sw/cmsdist#9173

[antoniovilela]

+1