HGCal raw data handling: Unpacker, Geometry, Local Reco #45665
+3,531
−2,238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45665/41204
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
assign hgcal-dpg |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45665/41205
|
|
New categories assigned: hgcal-dpg @rovere,@cseez,@pfs,@felicepantaleo you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
A new Pull Request was created by @IzaakWN for master. It involves the following packages:
The following packages do not have a category, yet: DataFormats/HGCalRecHit @Dr15Jones, @antoniovagnerini, @bsunanda, @civanch, @cmsbuild, @consuegs, @cseez, @felicepantaleo, @francescobrivio, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @nothingface0, @perrotta, @pfs, @rovere, @rvenditti, @saumyaphor4252, @smuzaffar, @srimanob, @subirsarkar, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
makortel
reviewed
Aug 7, 2024
|
+heterogeneous |
The following is a squashed commit of the contributions of different people Co-authored-by: IzaakWN <iwn_@hotmail.com> Co-authored-by: Lovisa <lovisa.rygaard@cern.ch> Co-authored-by: Matti Kortelainen <matti.kortelainen@cern.ch> Co-authored-by: Pedro Silva <psilva@cern.ch> Co-authored-by: Yulun Miao <60363605+yulunmiao@users.noreply.github.com> Co-authored-by: ineuteli <izaak.neutelings@cern.ch> Co-authored-by: ywkao <ywkao@hep1.phys.ntu.edu.tw> A summary of contents follows. Note this has been edited (ammended by @pfs): - HGCal Electronics Mapping for alpaka (#161) - add dense index map for HGCalElectronicsId - add getMaxDataSize & getMaxERxSize functions - fix getDenseIndex bug; add typcode map to ModuleIndexer (to retrieve module dense index offset); use regexp for type code - add getFedAndModuleIndex; rename getDenseIndex -> getIndexForModule(Data) for elecID - add typecode regexp; pass typecode to modIndexer_.processNewModule - adding dense index info producer - adding hgcalmapping customise - fix misunderstanding in max data size expected from indexer - remove_if was missing a call to std::vector::erase to effectively remove unused entries - typecodemap was missing a reset with the final indices - usage of command line options was missing in module map tester - do not use moduleLUT in DenseIndexInfoESProducer!! it has the full dimensions before trimming to the actual number of ECON-Ds in a FED - Add irot to module mapper (#134) - move variables to private, use getters and move bulky code to .cc in HGCalMappingModuleIndexer / apply code checks - CondFormats - add calibrations Alpaka ESProducer - rename ES_HGCal*Parameter.cc -> HGCal*ParameterHostCollection.cc for clarity - moving to single record as all conds produced have the same IOV - add HGCal configuration ESProducers + record + tester - Record descriptions added - Re-introducing 1 record per payload, addressing additional code comments - rename ES_HGCal*Parameter.cc -> HGCal*ParameterHostCollection.cc for clarity - rename HGCal*ParameterHostCollection.cc -> HGCal*ParameterDeviceCollection.cc for clarity - rename 'HGCal.*(Device|Host)Collection -> (Device|Host)' for readability; move calib SoAs to CondFormats/HGCalObjects/; move TestHGCalRecHitESProducers to test - fill HGCal config structs for unpacker (header marks, charMode) - read HGCal FED & ECON-D configuration from JSON - Adding digi SoAs - moving digi soa filler to alpaka and adding extra tools - rename 'HGCal.*(Device|Host)Collection -> HGCal.*(Device|Host)' for readability - Refactor unpacker. - parse arrays of gain-dependent calibration parameters in eRx-blocks (simplified in latter commits to remove explicit gain-dependence) - add missing Noise attribute - Convert ECON-D payload to 32b words. - rebase the unpacker on denseIdx and SoA digis - Moving emulators to SimCalorimetry/HGCalSimAlgos, adapting paths - fix undefined left shift in HGCalRawDataPackingTools.cc; remove duplicate line in HGCalMappingTools.h (32 -> 31 to solve undefined left shift) - SoA format of HGCal ECON-D header - Unpack header information to HGCalECONDInfoSoA; Add in quality checks for ECON-D - Update unpacker to use HGCalConfiguration structure - Add flags for passthrough ECON-Ds - Fix the number of channel in eRx;Add default flag for digi, representing digi not read in raw data - Add parsing function for econd flag; renaming HGCalECONDInfo to HGCalECONDPacketInfo - Add in common mode in ECOND packet information - enable FED-level Parallelization through config - Remove change of location when something wrong in S-Link trailer - Add HGCalRecHit - add DIGI2RECO calibration algorithms (see https://gitlab.cern.ch/hgcal-dpg/hgcal-comm/-/merge_requests/3)[C; remove detId/elecId from SoAs (should be redundant since common indexer); add HGCROCChannelDataFrame<HGCalDetId> to classes_def.xml - Move HGCalRawDataDefinitions.h. - Update and rename HGCalRecHitProducer.cc to HGCalRecHitProducers.cc - update calibration kernels - bugfix in the cm Sum - fill rec hitflags - update kernel after closure - swap arguments in tot kernel - Code formats / checks - Removing unused includes and delarations - Re-introducing headers.h file needed for serialization classes - Remove data and change locations to cms-data folder - moving to printf, removing unused product, and message logger - int -> uint32_t; uncomment debugging print out - Change to LogDebug
pfs
force-pushed
the
dev/hackathon_base_CMSSW_14_1_X
branch
from
7a71603 to
ed8369d
Compare
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-started
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45665/43178 |
|
Pull request #45665 was updated. @Dr15Jones, @Moanwar, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @cseez, @felicepantaleo, @francescobrivio, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @pfs, @rovere, @srimanob, @subirsarkar can you please check and sign again. |
|
please test |
|
+hgcal-dpg |
cmsbuild
added
tests-started
hgcal-dpg-approved
and removed
tests-pending
hgcal-dpg-pending
labels
|
+1 Size: This PR adds an extra 44KB to repository Comparison SummarySummary:
|
|
+1 |
|
+1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This adds work from the Raw Data Handling Group of the HGCal DPG.
This PR includes:
EventFilter/HGCalRawToDigi→SimCalorimetry/HGCalSimAlgos), they will be subject of a future PR.Geometry/HGCalMapping.CondFormats.DataFormats/HGCalDigi/interface/HGCalDigiSoA.h.AddingRemoved from this PR (see below).TH2Polyfor DQM.We kindly request this to be merged into
CMSSW_14_1_0_pre7in time for the coming September test beams where validation will continue.PR validation:
No CMSSW workflow is impacted by this PR.
We validated this with test beam data last week. You can find latest DQM plots here: http://hgc-vm-2024.cern.ch:8070/dqm/online-dev/session
Further documentation