[ROOTMaster] Fix include for RNTuple* #44256

iarspider · 2024-02-28T09:40:10Z

PR description:

Fix include for RNTupleWriterOptions after [ntuple] split RNTupleOptions header root-project/root#14799;
Fix renaming of RCollectionNTupleWriter class to RNTupleCollectionWriter, add new include ([ntuple] split off RNTupleCollectionWriter header root-project/root#14797);
Reapply changes from [ROOT6] RPageSinkFile is now in ROOT::Experimental::Internal namespace #44032.

PR validation:

Bot tests in cms-sw/cmsdist#9034

cmsbuild · 2024-02-28T09:40:36Z

cms-bot internal usage

cmsbuild · 2024-02-28T09:45:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44256/39267

This PR adds an extra 16KB to repository

cmsbuild · 2024-02-28T09:46:05Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-02-28T10:43:19Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44256/39269

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44256/39269/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44256/39269/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2024-02-28T10:56:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44256/39270

This PR adds an extra 20KB to repository

cmsbuild · 2024-02-28T10:57:05Z

Pull request #44256 was updated. @hqucms, @vlimant, @cmsbuild can you please check and sign again.

makortel · 2024-02-28T14:17:44Z

FYI @Dr15Jones @dan131riley @nsmith-

vlimant · 2024-02-28T15:35:05Z

enable nano

vlimant · 2024-02-28T15:35:10Z

please test

cmsbuild · 2024-02-28T18:11:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5552da/37795/summary.html
COMMIT: e9ab792
CMSSW: CMSSW_14_1_X_2024-02-28-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44256/37795/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 92 lines to the logs
Reco comparison results: 46 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3011576
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3011551
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16430
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16430
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 40 log files, 20 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.551	2.551	0.000 ( +0.0% )	5.29	5.05	+4.7%	2.220	2.217
2500.001	2.700	2.700	0.000 ( +0.0% )	4.71	4.77	-1.1%	2.660	2.659
2500.002	2.641	2.641	0.000 ( +0.0% )	4.88	4.89	-0.2%	2.631	2.637
2500.01	1.322	1.322	0.000 ( +0.0% )	9.83	9.88	-0.5%	2.281	2.338
2500.011	1.745	1.745	0.000 ( +0.0% )	5.25	5.27	-0.5%	2.517	2.528
2500.012	1.586	1.586	0.000 ( +0.0% )	7.60	7.59	+0.1%	2.431	2.375
2500.1	2.194	2.194	0.000 ( +0.0% )	5.32	5.32	-0.1%	2.060	2.058
2500.2	2.310	2.310	0.000 ( +0.0% )	6.09	6.05	+0.6%	1.973	1.971
2500.21	1.185	1.185	0.000 ( +0.0% )	4.34	4.35	-0.3%	2.259	2.268
2500.211	1.549	1.549	0.000 ( +0.0% )	3.82	3.78	+1.1%	2.333	2.345
2500.3	2.060	2.060	0.000 ( +0.0% )	12.60	12.65	-0.4%	1.963	1.953
2500.31	1.258	1.258	0.000 ( +0.0% )	20.44	20.32	+0.6%	2.352	2.333
2500.311	1.644	1.644	0.000 ( +0.0% )	13.55	13.57	-0.1%	2.432	2.435
2500.312	7.159	7.159	0.000 ( +0.0% )	1.41	1.37	+2.8%	1.679	1.681
2500.313	1.564	1.564	0.000 ( +0.0% )	6.73	6.92	-2.7%	1.034	1.034
2500.314	1.157	1.157	0.000 ( +0.0% )	14.50	13.89	+4.4%	2.176	2.172
2500.4	2.060	2.060	0.000 ( +0.0% )	12.68	12.57	+0.8%	1.956	1.953
2500.401	1.817	1.817	0.000 ( +0.0% )	10.79	10.87	-0.7%	1.812	1.811
2500.5	19.575	19.575	0.000 ( +0.0% )	1.24	1.27	-2.0%	1.343	1.349

…root#14799

iarspider · 2024-03-01T08:24:36Z

please test

cmsbuild · 2024-03-01T08:30:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44256/39299

This PR adds an extra 20KB to repository

cmsbuild · 2024-03-01T08:30:33Z

Pull request #44256 was updated. @hqucms, @vlimant can you please check and sign again.

cmsbuild · 2024-03-01T11:32:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5552da/37845/summary.html
COMMIT: c730a32
CMSSW: CMSSW_14_1_X_2024-02-29-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44256/37845/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 94 lines to the logs
Reco comparison results: 43 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3338784
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3338762
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 166 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 16430
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 16430
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 40 log files, 20 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.551	2.551	0.000 ( +0.0% )	5.20	5.29	-1.7%	2.154	2.179
2500.001	2.700	2.700	0.000 ( +0.0% )	4.67	4.69	-0.5%	2.591	2.586
2500.002	2.641	2.641	0.000 ( +0.0% )	4.87	4.87	+0.0%	2.571	2.589
2500.01	1.322	1.322	0.000 ( +0.0% )	9.43	9.58	-1.6%	2.236	2.265
2500.011	1.745	1.745	0.000 ( +0.0% )	5.10	5.16	-1.0%	2.413	2.417
2500.012	1.586	1.586	0.000 ( +0.0% )	7.31	7.40	-1.2%	2.294	2.390
2500.1	2.194	2.194	0.000 ( +0.0% )	5.27	5.30	-0.5%	2.055	2.061
2500.2	2.310	2.310	0.000 ( +0.0% )	6.03	6.06	-0.5%	1.890	1.976
2500.21	1.185	1.185	0.000 ( +0.0% )	4.31	4.34	-0.6%	2.214	2.263
2500.211	1.549	1.549	0.000 ( +0.0% )	3.73	3.73	+0.0%	2.240	2.237
2500.3	2.060	2.060	0.000 ( +0.0% )	12.48	12.46	+0.1%	1.960	1.959
2500.31	1.258	1.258	0.000 ( +0.0% )	19.87	19.99	-0.6%	2.321	2.360
2500.311	1.644	1.644	0.000 ( +0.0% )	13.14	13.46	-2.3%	2.305	2.439
2500.312	7.159	7.159	0.000 ( +0.0% )	1.30	1.41	-7.3%	1.679	1.688
2500.313	1.564	1.564	0.000 ( +0.0% )	6.23	6.74	-7.6%	1.031	1.036
2500.314	1.157	1.157	0.000 ( +0.0% )	13.91	13.30	+4.6%	2.162	2.177
2500.4	2.060	2.060	0.000 ( +0.0% )	12.05	12.26	-1.8%	1.894	1.917
2500.401	1.817	1.817	0.000 ( +0.0% )	9.84	10.46	-5.9%	1.809	1.802
2500.5	19.575	19.575	0.000 ( +0.0% )	1.05	0.92	+14.2%	1.347	1.343

vlimant · 2024-03-02T10:33:24Z

+1

cmsbuild · 2024-03-02T10:33:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-03-03T23:50:13Z

+1

Revert #44256 - merged too early

[ROOTMaster] Fix include for RNTuple* (redo of #44256)

cmsbuild added this to the CMSSW_14_1_X milestone Feb 28, 2024

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Feb 28, 2024

iarspider mentioned this pull request Feb 28, 2024

Updated root to tip of branch master cms-sw/cmsdist#9034

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 28, 2024

iarspider changed the title ~~[ROOTMaster] Fix include for RNTupleWriterOptions after root-project/root#14799~~ [ROOTMaster] Fix include for RNTuple* Feb 28, 2024

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 28, 2024

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Feb 28, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 28, 2024

cmsbuild added tests-started and removed tests-pending labels Feb 28, 2024

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 1, 2024

[ROOTMaster] Fix include for RNTupleWriterOptions after root-project/…

c730a32

…root#14799

iarspider force-pushed the rntupleoptions-fix branch from 8d98a7a to c730a32 Compare March 1, 2024 08:24

cmsbuild added tests-started and removed tests-pending labels Mar 1, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 1, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 1, 2024

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Mar 2, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 3, 2024

cmsbuild merged commit 76b5b17 into cms-sw:master Mar 3, 2024
13 checks passed

iarspider added a commit to iarspider/cmssw that referenced this pull request Mar 4, 2024

Revert cms-sw#44256 - merged too early

2bcf9bc

iarspider mentioned this pull request Mar 4, 2024

Revert #44256 - merged too early #44292

Merged

cmsbuild added a commit that referenced this pull request Mar 5, 2024

Merge pull request #44292 from iarspider/revert-44256

07bcc38

Revert #44256 - merged too early

iarspider added a commit to iarspider/cmssw that referenced this pull request Mar 6, 2024

[ROOTMaster] Fix include for RNTuple* (redo of cms-sw#44256)

9cc8c10

iarspider mentioned this pull request Mar 6, 2024

[ROOTMaster] Fix include for RNTuple* (redo of #44256) #44328

Merged

cmsbuild added a commit that referenced this pull request Mar 13, 2024

Merge pull request #44328 from iarspider/redo-44256

980274e

[ROOTMaster] Fix include for RNTuple* (redo of #44256)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ROOTMaster] Fix include for RNTuple* #44256

[ROOTMaster] Fix include for RNTuple* #44256

iarspider commented Feb 28, 2024 •

edited

Loading

cmsbuild commented Feb 28, 2024 •

edited

Loading

cmsbuild commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

makortel commented Feb 28, 2024

vlimant commented Feb 28, 2024

vlimant commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

iarspider commented Mar 1, 2024

cmsbuild commented Mar 1, 2024

cmsbuild commented Mar 1, 2024

cmsbuild commented Mar 1, 2024

vlimant commented Mar 2, 2024

cmsbuild commented Mar 2, 2024

antoniovilela commented Mar 3, 2024

[ROOTMaster] Fix include for RNTuple* #44256

[ROOTMaster] Fix include for RNTuple* #44256

Conversation

iarspider commented Feb 28, 2024 • edited Loading

PR description:

PR validation:

cmsbuild commented Feb 28, 2024 • edited Loading

cmsbuild commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

makortel commented Feb 28, 2024

vlimant commented Feb 28, 2024

vlimant commented Feb 28, 2024

cmsbuild commented Feb 28, 2024

Comparison Summary

NANO Comparison Summary

iarspider commented Mar 1, 2024

cmsbuild commented Mar 1, 2024

cmsbuild commented Mar 1, 2024

cmsbuild commented Mar 1, 2024

Comparison Summary

NANO Comparison Summary

vlimant commented Mar 2, 2024

cmsbuild commented Mar 2, 2024

antoniovilela commented Mar 3, 2024

iarspider commented Feb 28, 2024 •

edited

Loading

cmsbuild commented Feb 28, 2024 •

edited

Loading