Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ntuple] split RNTupleOptions header #14799

Merged
merged 1 commit into from
Feb 22, 2024
Merged

[ntuple] split RNTupleOptions header #14799

merged 1 commit into from
Feb 22, 2024

Conversation

jblomer
Copy link
Contributor

@jblomer jblomer commented Feb 22, 2024

Split RNTupleOptions header in RNTupleReadOptions, RNTupleWriteOptions, and RNTupleWriteOptionsDaos.

@jblomer jblomer self-assigned this Feb 22, 2024
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

@phsft-bot
Copy link
Collaborator

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2024-02-22T14:02:36.400Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1128 (message):

@jblomer
[ntuple] split RNTupleOptions header
3c0a1d9 
Split RNTupleOptions header in RNTupleReadOptions, RNTupleWriteOptions,
and RNTupleWriteOptionsDaos.
@jblomer jblomer force-pushed the nutple-header-split07 branch from 24e17ad to 3c0a1d9 Compare February 22, 2024 14:57
@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link
Collaborator

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

@github-actions GitHub Actions
Copy link

Test Results

    10 files      10 suites   1d 19h 6m 10s ⏱️
 2 520 tests  2 519 ✅ 0 💤 1 ❌
24 481 runs  24 480 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 3c0a1d9.

@jblomer jblomer merged commit 9c91eee into root-project:master Feb 22, 2024
12 of 17 checks passed
@jblomer jblomer deleted the nutple-header-split07 branch February 22, 2024 21:56
iarspider added a commit to iarspider/cmssw that referenced this pull request Feb 28, 2024
@iarspider
[ROOTMaster] Fix include for RNTupleWriterOptions after root-project/…
c7a598d 
…root#14799
@iarspider iarspider mentioned this pull request Feb 28, 2024
Merged
iarspider added a commit to iarspider/cmssw that referenced this pull request Mar 1, 2024
@iarspider
[ROOTMaster] Fix include for RNTupleWriterOptions after root-project/…
c730a32 
…root#14799
@iarspider iarspider mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hahnjo hahnjo hahnjo approved these changes

@pcanal pcanal Awaiting requested review from pcanal

@vepadulano vepadulano Awaiting requested review from vepadulano

@enirolf enirolf Awaiting requested review from enirolf

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@couet couet Awaiting requested review from couet couet is a code owner

Assignees

@jblomer jblomer

Labels
in:RNTuple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jblomer @phsft-bot @hahnjo