Updated quality bits of KMTF

[bachtis]

PR description:

Per request of the L1 DPG based on studies of the BPH group we are sightly modifying the quality bit definition of KMTF

PR validation:

Tests of the performance and tests between hardware and emulator have been performed

Note that this is a minor change of the previous code . No propagated changes needed downstream for this change

@eyigitba @drkovalskyi @gmelachr

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44432/39507

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44432/39507/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44432/39507/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[aloeliger]

@bachtis Could you really quickly hit the auto-formatting (scram build code-format) for this PR? This should be quick after that.

[bachtis]

@bachtis Could you really quickly hit the auto-formatting (scram build code-format) for this PR? This should be quick after that.

yep

[bachtis]

@aloeliger the code format patch is done

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44432/39533

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @bachtis for master.

It involves the following packages:

• L1Trigger/L1TMuonBarrel (l1)

@cmsbuild, @aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@JanFSchulte, @dinyar, @Martin-Grunewald, @eyigitba, @missirol, @thomreis this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a75efc/38249/summary.html
COMMIT: 3dec535
CMSSW: CMSSW_14_1_X_2024-03-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44432/38249/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 108 lines to the logs
• Reco comparison results: 60 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297369
• DQMHistoTests: Total failures: 1598
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3295751
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1

[missirol]

@cms-sw/l1-l2 @eyigitba , should this PR be backported to 14_0_X ?

[eyigitba]

@missirol , yes we need the backport to 14_0_X, although it's not urgent. @bachtis can you make this backport PR?