[CPP20][GEOMETRY] Replace some enums with constexpr ints

[iarspider]

PR description:

Replace some enums with constexpr ints to avoid deprecated enum arithmetics. Replaces #44488 following @makortel's suggestion.

PR validation:

Bot tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44514/39638

• This PR adds an extra 36KB to repository

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/EcalDetId (simulation)
• DataFormats/HcalDetId (simulation)
• Geometry/CaloTopology (geometry)
• Geometry/EcalAlgo (geometry)
• Geometry/ForwardGeometry (geometry)

@makortel, @mdhildreth, @civanch, @bsunanda, @Dr15Jones can you please review it and eventually sign? Thanks.
@ReyerBand, @bsunanda, @fabiocos, @missirol, @argiro, @mariadalfonso, @abdoulline, @thomreis, @rovere, @wang0jin, @rchatter this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f40703/38349/summary.html
COMMIT: 2a3d9c1
CMSSW: CMSSW_14_1_CPP20_X_2024-03-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @valsdav DeepTau - Do not call TF inference with empty grid #44455
• @Dr15Jones Use default operator= in CondFormats/CSCObjects #44462
• @mmusich add a python compilation unit test for DQM online clients #44412
• @fwyzard Improve error handling in GPU callbacks #44476
• @fwyzard Improve the memory usage in the alpaka pixel reconstruction #44458
• @vlimant adding JME nano in autoNano #44087
• @mmusich TkAl: fix PV validation and PV resolution submission scripts #44467
• @Dr15Jones Apply rule-of-5 to ESPreFunctorDecorator #44483
• @Dr15Jones Removed explicit copy ctr in TrackStub #44482
• @valsdav Improve handling of TF CUDA tests for 14_1_X #44376
• @aehart KalmanFilter fix for Phase 2 L1 tracking #44427
• @smuzaffar Remove unused strstream to fix the deprecated header warning #44426
• @swagata87 Produce r9 and trackIso(hollow cone) in EGamma development path #44423
• @stahlleiton Add use of unsubtracted jets in RecoBTag info producers #44422
• @watson-ij Allow storing 2024 geometry in GEMGeometryParsFromDD #44429
• @makortel Fix plugin library name AlpakaCore/plugins/BuildFile.xml #44445
• @Dr15Jones Use standard file names in DQM/HcalTasks config files #44408
• @saumyaphor4252 Add GEM channel and strip payload dump utilities #44460
• @fwyzard Fix track sort order in PixelTrackProducerFromSoAAlpaka #44441
• @mmusich reverts #44054 and #44389 #44466
• @kyungminparkdrums Change FEStatus flag labels in ECAL DQM #44402
• @abdoulline HCAL proprietary RelVal machinery update #43953
• @Dr15Jones Use standard naming for configs in CondTools/RunInfo #44407
• @iarspider [AArch64, PowerPC] Fix deprecated-copy warnings in extBasic{2,3}DVector #44448
• @iarspider [CPP20][RECONSTRUCTION] Remove deprecated enum arithmetic #44490
• @iarspider [CPP20][Analysis] Remove deprecated enum arithmetic #44486
• @germanfgv Add NanoAOD flavours parameter to PromptReco #44430
• @hsinweihsia modified for Phase2 DeepJet retraining model #44431
• @bachtis Updated quality bits of KMTF  #44432
• @mmusich MillePedeAlignmentAlgorithm: add a unit test for the mille step #44434
• @fwyzard Update the HLT alpaka customisation #44439

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f40703/38349/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f40703/38349/git-merge-result

RelVals

• 24896.0

----- Begin Fatal Exception 22-Mar-2024 18:55:20 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV02_PhaseII/DeepJet_retraining_phase2_new_inputs.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/CMSSW_14_1_CPP20_X_2024-03-18-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24896.0_CloseByPGun_CE_E_Front_120um+2026D98


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Types.py(887): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(519): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

• 24900.0

----- Begin Fatal Exception 22-Mar-2024 18:55:52 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV02_PhaseII/DeepJet_retraining_phase2_new_inputs.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/CMSSW_14_1_CPP20_X_2024-03-18-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24900.0_CloseByPGun_CE_H_Coarse_Scint+2026D98


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Types.py(887): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(519): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

• 24834.0

----- Begin Fatal Exception 22-Mar-2024 18:59:06 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV02_PhaseII/DeepJet_retraining_phase2_new_inputs.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/CMSSW_14_1_CPP20_X_2024-03-18-1100/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44514/38349/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24834.0_TTbar_14TeV+2026D98


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Types.py(887): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(384): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Mixins.py(519): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1216): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02829/el8_amd64_gcc12/cms/cmssw/CMSSW_14_1_CPP20_X_2024-03-18-1100/src/FWCore/ParameterSet/python/Config.py(1489): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 24834.911
• 25034.999

[iarspider]

RelVal failures are unrelated.

[iarspider]

please test
let's retrigger to get clean tests

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f40703/38404/summary.html
COMMIT: 2a3d9c1
CMSSW: CMSSW_14_1_X_2024-03-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44514/38404/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297537
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297508
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[bsunanda]

+geometry

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f40703/38446/summary.html
COMMIT: 2a3d9c1
CMSSW: CMSSW_14_1_CPP20_X_2024-03-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44514/38446/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2448 lines to the logs
• Reco comparison results: 120 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297537
• DQMHistoTests: Total failures: 505
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297012
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1