-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a python compilation unit test for DQM online clients #44412
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44412/39487
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@rvenditti, @syuvivida, @antoniovagnerini, @tjavaid, @nothingface0, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44412/39490
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44412/39491
|
Pull request #44412 was updated. @nothingface0, @syuvivida, @tjavaid, @rvenditti, @antoniovagnerini, @cmsbuild can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3e405/38161/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In preparing #44384 I noticed that the test coverage of DQM online clients is somewhat poor since the existing unit tests do not contemplate all the possible run keys that can be exercised at P5.
It would be costly in terms of execution time and in terms of storage space (to store the input RAW data / streamer files) to cover all the possible uses cases in a battery of unit tests that actually execute
cmsRun
of these configurations, but at least they could be compiled to spot obvious configuration problems (as the ones resolved in #44384).This is proposed in this PR.
In order to make the new unit test run, some leftover configuration issues have been fixed. I assume they are somehow irrelevant as they pertain to combinations that are probably never run online, but nevertheless to avoid too much ad hoc handling in the test they are fixed here.
PR validation:
The newly added unit tests:
scram b runtests_TestDQMOnlineClients-compilation_[*]
run fine.[*] =
'pp_run'
,'pp_run_stage1'
,'cosmic_run'
,'cosmic_run_stage1'
,'hi_run'
,'hpu_run'
,'commissioning_run'
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but if desired it can be backported to CMSSW_14_0_X for data-taking purposes