Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a python compilation unit test for DQM online clients #44412

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 15, 2024

PR description:

In preparing #44384 I noticed that the test coverage of DQM online clients is somewhat poor since the existing unit tests do not contemplate all the possible run keys that can be exercised at P5.
It would be costly in terms of execution time and in terms of storage space (to store the input RAW data / streamer files) to cover all the possible uses cases in a battery of unit tests that actually execute cmsRun of these configurations, but at least they could be compiled to spot obvious configuration problems (as the ones resolved in #44384).
This is proposed in this PR.
In order to make the new unit test run, some leftover configuration issues have been fixed. I assume they are somehow irrelevant as they pertain to combinations that are probably never run online, but nevertheless to avoid too much ad hoc handling in the test they are fixed here.

PR validation:

The newly added unit tests: scram b runtests_TestDQMOnlineClients-compilation_[*] run fine.

[*] = 'pp_run','pp_run_stage1','cosmic_run','cosmic_run_stage1','hi_run','hpu_run','commissioning_run'

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but if desired it can be backported to CMSSW_14_0_X for data-taking purposes

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44412/39487

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/Physics (dqm)

@rvenditti, @syuvivida, @antoniovagnerini, @tjavaid, @nothingface0, @cmsbuild can you please review it and eventually sign? Thanks.
@ReyerBand, @rappoccio, @thomreis, @threus, @wang0jin, @batinkov, @rchatter, @argiro, @francescobrivio this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44412/39490

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44412/39491

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44412 was updated. @nothingface0, @syuvivida, @tjavaid, @rvenditti, @antoniovagnerini, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3e405/38161/summary.html
COMMIT: 486b0a7
CMSSW: CMSSW_14_1_X_2024-03-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44412/38161/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented Mar 19, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0130c36 into cms-sw:master Mar 20, 2024
11 checks passed
@mmusich mmusich deleted the compileClients branch March 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants