Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] add a python compilation unit test for DQM online clients #44472

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 19, 2024

backport of #44412

PR description:

In preparing #44385 I noticed that the test coverage of DQM online clients is somewhat poor since the existing unit tests do not contemplate all the possible run keys that can be exercised at P5.
It would be costly in terms of execution time and in terms of storage space (to store the input RAW data / streamer files) to cover all the possible uses cases in a battery of unit tests that actually execute cmsRun of these configurations, but at least they could be compiled to spot obvious configuration problems (as the ones resolved in #44384).
This is proposed in this PR.
In order to make the new unit test run, some leftover configuration issues have been fixed. I assume they are somehow irrelevant as they pertain to combinations that are probably never run online, but nevertheless to avoid too much ad hoc handling in the test they are fixed here.

PR validation:

The newly added unit tests: scram b runtests_TestDQMOnlineClients-compilation_[*] run fine.

[*] = 'pp_run','pp_run_stage1','cosmic_run','cosmic_run_stage1','hi_run','hpu_run','commissioning_run'

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44412 in the 2024 data-taking release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/Physics (dqm)

@tjavaid, @nothingface0, @rvenditti, @antoniovagnerini, @cmsbuild, @syuvivida can you please review it and eventually sign? Thanks.
@rappoccio, @batinkov, @francescobrivio, @ReyerBand, @rchatter, @threus, @wang0jin, @thomreis, @argiro this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Mar 19, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2dace4/38269/summary.html
COMMIT: 88c605b
CMSSW: CMSSW_14_0_X_2024-03-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44472/38269/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 109 lines to the logs
  • Reco comparison results: 38 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346212
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346190
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Mar 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6755888 into cms-sw:CMSSW_14_0_X Mar 21, 2024
10 checks passed
@mmusich mmusich deleted the compileClients_14_0_X branch March 21, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants