Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GEM channel and strip payload dump utilities #44460

Merged

Conversation

saumyaphor4252
Copy link
Contributor

@saumyaphor4252 saumyaphor4252 commented Mar 19, 2024

PR description:

The PR adds the following three records to CondCore/Utilities scripts to dump the payload content. The relevant CMS Talk post is [1].

  • GEMChMapRcd
  • GEMMaskedStrips
  • GEMDeadStrips

The first record is already in the GTs and the latter 2 will be needed in the online GTs to allow strip masking in [2].

[1] https://cms-talk.web.cern.ch/t/request-for-2024-data-taking-from-gem/36149
[2] #44085

FYI @yeckang

PR validation:

Following commands now run

conddb dump GEMChMap_2024_v2 > GEMChMap_2024_v2.xml
conddb dump GEMMaskedStrips_2024_v2 > GEMMaskedStrips_2024_v2.xml
conddb dump GEMDeadStrips_dummy_v1 > GEMDeadStrips_dummy_v1.xml

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44460/39540

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44460/39541

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @saumyaphor4252 for master.

It involves the following packages:

  • CondCore/Utilities (db)

@perrotta, @francescobrivio, @cmsbuild, @consuegs, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@rsreds, @PonIlya, @yuanchao, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c56700/38251/summary.html
COMMIT: 760f7be
CMSSW: CMSSW_14_1_X_2024-03-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44460/38251/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@francescobrivio
Copy link
Contributor

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6b884c8 into cms-sw:master Mar 20, 2024
11 checks passed
@saumyaphor4252 saumyaphor4252 deleted the alca-GEM_Channel_Dump_Content branch November 1, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants