Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default operator= in CondFormats/CSCObjects #44462

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This avoids a clang warning about deprecated auto generated copy constructors.

PR validation:

Building code under CMSSW_14_1_CLANG_X_2024-03-18-2300 no longer issues the warnings.

This avoids a clang warning about deprecated auto generated
copy constructors.
@Dr15Jones
Copy link
Contributor Author

@makortel FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2024

cms-bot internal usage

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44462/39546

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • CondFormats/CSCObjects (alca, db)

@consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@seemasharmafnal, @rsreds, @tocheng, @PonIlya, @mmusich, @giovanni-mocellin, @ptcox, @yuanchao this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

(Note mostly for myself: the removed copy constructors did exactly what is expected from the default ones. As soon as the tests pass, this PR can get approved by AlCa/DB)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eeadc9/38252/summary.html
COMMIT: 23e2e8a
CMSSW: CMSSW_14_1_X_2024-03-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44462/38252/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants