-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default operator= in CondFormats/CSCObjects #44462
Conversation
This avoids a clang warning about deprecated auto generated copy constructors.
@makortel FYI |
cms-bot internal usage |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44462/39546
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
(Note mostly for myself: the removed copy constructors did exactly what is expected from the default ones. As soon as the tests pass, this PR can get approved by AlCa/DB) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eeadc9/38252/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This avoids a clang warning about deprecated auto generated copy constructors.
PR validation:
Building code under CMSSW_14_1_CLANG_X_2024-03-18-2300 no longer issues the warnings.