Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] add a unit test for conversion of millepede.res files into DB payloads #44705

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 11, 2024

backport of #44570

PR description:

This PR is a continuation of the series started with #37211 and continued with #43935 and #44434 about unit tests for the MP-II based alignment workflow and adds a new unit test to allow the testing of the conversion of millepede.res files into DB (sqlite payloads). This is performed using the option

process.AlignmentProducer.algoConfig.mode = 'pedeRead'     

of AlignmentProducer and it's a useful to avoid re-running the pede step once a millepede.res is already avaialbles.

PR validation:

Run successfully:

scram b runtests_test_PedeConversion

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #44570

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)

@saumyaphor4252, @consuegs, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@yuanchao, @adewit, @tlampen, @mmusich, @tocheng, @rsreds this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 11, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 11, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cf216/38778/summary.html
COMMIT: 272b7e4
CMSSW: CMSSW_14_0_X_2024-04-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44705/38778/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 49 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3308451
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3308422
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4109f34 into cms-sw:CMSSW_14_0_X Apr 12, 2024
10 checks passed
@mmusich mmusich deleted the mm_dev_pedeConversionTest branch April 12, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants