Update and fix of DQM plots for PPS timing detectors

[grzanka]

PR description:

This PR provides fix for the wrongly produced plot of correlation between tracks in PPS timing detectors (for 220cyl and 220nr_hr). Fixed plot looks like this:

Previous code contained bug related to assignment of a track to given pot.

The code as well includes several cosmetic adjustment of the plot binning and titles.

Moreover leading and trailing edge plots were added to "per place" plot group.

PR validation:

Manually running script which produced DQM plot from the PromptReco ZeroBias files sample /store/data/Run2024B/ZeroBias/AOD/PromptReco-v1 for run for run 379154 :

from Configuration.Eras.Era_Run3_cff import Run3

process = cms.Process('RECODQM', Run3)

# command  line options
import FWCore.ParameterSet.VarParsing as VarParsing
options = VarParsing.VarParsing ('analysis')
options.inputFiles= 'file:input.root'
options.maxEvents = -1 
options.parseArguments()

process.maxEvents = cms.untracked.PSet(
    input = cms.untracked.int32(options.maxEvents)
)

process.verbosity = cms.untracked.PSet( input = cms.untracked.int32(-1) )

# minimum of logs
process.MessageLogger = cms.Service("MessageLogger",
    cerr = cms.untracked.PSet(
        threshold = cms.untracked.string('INFO')
    )
)

# import of standard configurations
process.load('Configuration.StandardSequences.Services_cff')
process.load('FWCore.MessageService.MessageLogger_cfi')
process.load('Configuration.EventContent.EventContent_cff')
process.load('Configuration.StandardSequences.FrontierConditions_GlobalTag_cff')

# load DQM framework
process.load("DQM.Integration.config.environment_cfi")
process.dqmEnv.subSystemFolder = "CTPPS"
process.dqmEnv.eventInfoFolder = "EventInfo"
process.dqmSaver.path = ""
process.dqmSaver.tag = "CTPPS"

# raw data source
process.source = cms.Source("PoolSource",
    fileNames = cms.untracked.vstring(cms.untracked.vstring(options.inputFiles)),
)

from Configuration.AlCa.GlobalTag import GlobalTag
process.GlobalTag = GlobalTag(process.GlobalTag, 'auto:run3_data', '')

# local RP reconstruction chain with standard settings
process.load("RecoPPS.Configuration.recoCTPPS_cff")

process.load("DQM.Integration.config.FrontierCondition_GT_cfi")

# CTPPS DQM modules
process.load("DQM.CTPPS.ctppsDQM_cff")
process.ctppsDiamondDQMSource.excludeMultipleHits = cms.bool(True)
process.ctppsDiamondDQMSource.plotOnline = cms.untracked.bool(True)
process.ctppsDiamondDQMSource.plotOffline = cms.untracked.bool(True)
process.path = cms.Path(
    process.ctppsDQMCalibrationSource*
    process.ctppsDQMCalibrationHarvest
)

process.end_path = cms.EndPath(
    process.dqmEnv +
    process.dqmSaver
)

process.schedule = cms.Schedule(
    process.path,
    process.end_path
)

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44835/40078

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44835/40078/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44835/40078/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44835/40080

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @grzanka for master.

It involves the following packages:

• DQM/CTPPS (dqm)

@rvenditti, @antoniovagnerini, @syuvivida, @tjavaid, @nothingface0, @cmsbuild can you please review it and eventually sign? Thanks.
@fabferro this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a2bdc6/39089/summary.html
COMMIT: fad0cf1
CMSSW: CMSSW_14_1_X_2024-04-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44835/39089/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
25088.203 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 61 lines to the logs
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3326929
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 110
• DQMHistoTests: Total successes: 3326784
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1007.936 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0,... ): 34.812 KiB CTPPS/TimingDiamond
• DQMHistoSizes: changed ( 11634.0,... ): 69.500 KiB CTPPS/TimingDiamond
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[grzanka]

I've created a backport to 14_0_X here #44856

[mmusich]

type ctpps, bugfix

[antoniovilela]

@cms-sw/dqm-l2
Please sign the master PR before the backport.

[antoniovilela]

@cms-sw/dqm-l2
Please sign the master PR before the backport.

ping @cms-sw/dqm-l2

[tjavaid]

+1

• P5 tests OK with its 14_0_X backport Update and fix of DQM plots for PPS timing detectors [backport of 44835] #44856
• @grzanka could you please fix the description for "PSS timing detectors" -> "PPS timing detectors". Thanks!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1