Update and fix of DQM plots for PPS timing detectors [backport of 44835]

[grzanka]

PR description:

This is a backport of #44835

This PR provides fix for the wrongly produced plot of correlation between tracks in PPS timing detectors (for 220cyl and 220nr_hr).

Previous code contained bug related to assignment of a track to given pot.
The code as well includes several cosmetic adjustment of the plot binning and titles.
Moreover leading and trailing edge plots were added to "per place" plot group.

PR validation:

Manually running script which produced DQM plot from the PromptReco ZeroBias files sample /store/data/Run2024B/ZeroBias/AOD/PromptReco-v1 for run for run 379154

[cmsbuild]

A new Pull Request was created by @grzanka for CMSSW_14_0_X.

It involves the following packages:

• DQM/CTPPS (dqm)

@cmsbuild, @nothingface0, @tjavaid, @antoniovagnerini, @rvenditti, @syuvivida can you please review it and eventually sign? Thanks.
@fabferro this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

• Backported from Update and fix of DQM plots for PPS timing detectors #44835

[cmsbuild]

cms-bot internal usage

[mmusich]

@cmsbuild please test

[mmusich]

type ctpps, bugfix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f79e0/39124/summary.html
COMMIT: 32557e1
CMSSW: CMSSW_14_0_X_2024-04-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44856/39124/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 142 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3326485
• DQMHistoTests: Total failures: 2751
• DQMHistoTests: Total nulls: 110
• DQMHistoTests: Total successes: 3323604
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1007.936 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0,... ): 34.812 KiB CTPPS/TimingDiamond
• DQMHistoSizes: changed ( 11634.0,... ): 69.500 KiB CTPPS/TimingDiamond
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[antoniovagnerini]

+1
Tested in playback machine with collision run 379315 and since no issues observed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[tjavaid]

backport of #44835

[grzanka]

@cms-sw/dqm-l2 : it seems that #44835 was merged already , all the signatures are ready on this one, can it be merged ?

[tjavaid]

@cms-sw/dqm-l2 : it seems that #44835 was merged already , all the signatures are ready on this one, can it be merged ?

@grzanka , yes. @antoniovagnerini already signed this for DQM. So, it can be merged.
@antoniovilela gentle ping.

[rappoccio]

+1