Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix testTkHistoMap_cfg.py to include TrackerAdditionalParametersPerDet ESSource #45013

Merged
merged 1 commit into from
May 23, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 22, 2024

PR description:

Title says it all, needed because of #44576, fixes #44576 (comment) (failed unit test, see e.g. here ).

PR validation:

scram b runtests runs fine in the corresponding package.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2024

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2024

urgent

  • to fix IB unit tests

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45013/40296

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/SiStripCommon (dqm)

@nothingface0, @antoniovagnerini, @rvenditti, @cmsbuild, @tjavaid, @syuvivida can you please review it and eventually sign? Thanks.
@erikbutz, @idebruyn, @fioriNTU, @arossi83, @threus, @jandrea, @sroychow this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 22, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8920b9/39461/summary.html
COMMIT: d611e25
CMSSW: CMSSW_14_1_X_2024-05-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45013/39461/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented May 23, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5771776 into cms-sw:master May 23, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_fix_testTkHistoMap branch May 23, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants