-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introducing BigPixel for phase-2 InnerTracker in T39 geometry #44576
introducing BigPixel for phase-2 InnerTracker in T39 geometry #44576
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44576/39731
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
76f9689
to
12d11a2
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44576/39732
|
A new Pull Request was created by @emiglior for master. It involves the following packages:
@sunilUIET, @rvenditti, @tjavaid, @AdrianoDee, @perrotta, @subirsarkar, @bsunanda, @civanch, @saumyaphor4252, @mmusich, @mandrenguyen, @consuegs, @Dr15Jones, @fabiocos, @aloeliger, @Martin-Grunewald, @davidlange6, @epalencia, @srimanob, @cmsbuild, @rappoccio, @mdhildreth, @nothingface0, @antoniovilela, @miquork, @antoniovagnerini, @francescobrivio, @jfernan2, @syuvivida, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@cmsbuild, please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3f5fe0/39293/summary.html Comparison SummarySummary:
|
do we understand the origin of these changes? |
In case of phase-2 w/f, we changed the binning of the th2 digi-map |
this explains this.
what about the other failures? |
Still on ph-2 w/f, IIUC the failures are actually fired by tiny differences (but let me know if I am wrong). We observed something similar during the development of the code. localX(), localY(), pixel() in Geometry/TrackerGeometryBuilder/src/RectangularPixelPhase2Topology.cc (e.g. different rounding-off's) |
hi, any news on the missing signatures? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
#45013 should fix. |
DBG builds are broken, see for instance https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_DBG_X_2024-05-23-2300/Geometry/TrackerGeometryBuilder
|
#45038 ? |
PR description:
This PR is a follow-up of the draft PR#42454 (closed in Jan 2024).
The PR introduces the so-called BigPixels (elongated pixels between two readout chips) for the phase-2 InnerTracker following the implementation proposed in:
https://indico.cern.ch/event/1382902/contributions/5816585/attachments/2805475/4895325/Phase-2_IT_BigPix_TrkDPG.pdf
Description. BigPixels are introduced in the file pixelStructureTopology.xml or by using the TrackerAdditionalParametersPerDet rcd for geometries loaded from DB (none yet). Therefore, the PR restores the changes of the infrastructure needed for using the TrackerAdditionalParametersPerDet rcd, introduced for the bricked pixels and then removed with PR#40443 but without reintroducing the functions related to bricked pixels.
NOTE (similar to PR#34120): the record PTrackerAdditionalParametersPerDetRcd is consumed by the TrackerGeomBuilderFromGeometricDet, which is the same for Runs 2&3 and Phase 2. Therefore, this PR also modifies Runs 2&3, by including the new record.
Tracker geometry. The Tracker phase-2 test geometry in which BigPixels are introduced is T39, thus skipping versions T36-T37-T38 which are currently under development by @Raffaella07.
Implementation. Phase-2 pixels are now described by the class RectangularPhase2PixelTopology inheriting from PixelTopology. Code for Tracker local reco was adapted to work both the phase-1 pixels (RectangularPixelTopology) and with phase-2 pixels (RectangularPhase2PixelTopology). The function siPixelUtils::generic_position_formula(), used in PixelCPEGeneric, was modified in order to be used both for phase-1 and phase-2 BigPixels. A side-effect was to add to the abstract class PixelTopology the methods getPixelFractionInX() and getPixelFractionInY(). @fabiocos @martinamalberti: the implementation of these fcn in ProxyMTDTopology is just a placeholder to compile the code. Please let us know what the actual code should be.
PR validation:
compilation ok after git cms-checkdeps -a -A
scram b code-checks, code-format
scram b runtests
runTheMatrix.py -l limited -i all --ibeos
No changes are expected on phase-1 (set of tracking validation plots on a single muon sample on phase-1 geometry)
http://personalpages.to.infn.it/~migliore/BigPixels/SingleMuPt100-phase1/plots-20240323/
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport and no backport needed.
Specific w/f for test on T39: 30034.0
@gbardell @langufo @bartosik-hep
@mmusich @sroychow @mdelcourt FYI