-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix SiStripBadStrip_PayloadInspector
after merging of cms-sw/cmssw#45795
#45954
Conversation
type bug-fix |
cms-bot internal usage |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45954/41712 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
@cms-sw/db-l2 , can you please review this change? This fixes the failing unit tests in IBs |
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
urgent
|
+1 |
fixes #45952
PR description:
Title says it all, after #45795 was merged (in particular commit 68c2b44), it's not needed anymore to draw an empty "ghost" map as a background when some of the
SiStripTkMap
bins are empty.PR validation:
scram b runtests_testSiStripPayloadInspector
runs fine with this change.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A