Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plotting utilities to generate Tracker maps given user input #45795

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 25, 2024

PR description:

Title says it all. Useful when debugging conditions and or local reconstruction issues.
Supports two modes:

  • printPixelTrackerMap detid1 detid2 detid3 ...
  • printPixelTrackerMap --input-file input.txt

PR validation:

Run the script with a user generated list and obtained the following map:

Phase1PixelSummaryMap

Or:

 cut -d' ' -f1 $CMSSW_RELEASE_BASE/src/CalibTracker/SiStripCommon/data/SiStripDetInfo.dat | shuf -n 5000 | paste -sd ' ' - | xargs printStripTrackerMap

generates:

SiStripsTkMaps

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/TrackerRemapper (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@fioriNTU, @idebruyn, @jandrea, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45795 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45795 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@antoniovilela
Copy link
Contributor

ping (to make bot change milestone)

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Sep 3, 2024
@mmusich
Copy link
Contributor Author

mmusich commented Sep 4, 2024

ping @cms-sw/dqm-l2

@tjavaid
Copy link

tjavaid commented Sep 4, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 43fe74b into cms-sw:master Sep 6, 2024
11 checks passed
@mmusich mmusich deleted the mm_printPixelTrackerMap branch September 6, 2024 08:47
@smuzaffar
Copy link
Contributor

@mmusich , unit test testSiStripPayloadInspector from CondCore/SiStripPlugins package start failing with error [a]. I think change in the PR might be causing it, can you please check ?

[a]

## Exercising Threshold plots 
{"version": "1.0","annotations": {"payload_type":"SiStripThreshold","title":"SiStrip High threshold values (checked per APV)","type":"Histo1D","x_label":"SiStrip High threshold values (cheched per APV)","y_label":"entries"},"data": [ { "x":0, "y":5864 }, { "x":1, "y":6328 }, { "x":2, "y":6372 }, { "x":3, "y":6318 }, { "x":4, "y":5924 }, { "x":5, "y":217325 }, { "x":6, "y":4582 }, { "x":7, "y":4393 }, { "x":8, "y":4708 }, { "x":9, "y":5043 }]}
## Exercising SiStripTkMaps plots 

 *** Break *** segmentation violation



===========================================================
There was a crash.
This is the entire stack trace of all threads:
===========================================================
#0  0x000014af79e75e0b in waitpid () from /lib64/libc.so.6
#1  0x000014af79dc9747 in do_system () from /lib64/libc.so.6
#2  0x000014af7e063f3d in TUnixSystem::StackTrace() () from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02853/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-09-06-1100/external/el8_amd64_gcc12/lib/libCore.so
#3  0x000014af7e061a14 in TUnixSystem::DispatchSignals(ESignals) () from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02853/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-09-06-1100/external/el8_amd64_gcc12/lib/libCore.so
#4  <signal handler called>
#5  0x000014af83e75631 in SiStripTkMaps::drawMap(TCanvas&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) () from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02853/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-09-06-1100/lib/el8_amd64_gcc12/libDQMTrackerRemapper.so

@mmusich
Copy link
Contributor Author

mmusich commented Sep 7, 2024

@smuzaffar

can you please check ?

Not earlier than next week

@mmusich
Copy link
Contributor Author

mmusich commented Sep 9, 2024

can you please check ?

For the record, #45954 should fix it.

cmsbuild added a commit that referenced this pull request Sep 10, 2024
fix `SiStripBadStrip_PayloadInspector` after merging of #45795
youngwan-kim pushed a commit to youngwan-kim/cmssw that referenced this pull request Sep 11, 2024
jyoti299 pushed a commit to jyoti299/cmssw that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants