-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve plotting utilities to generate Tracker maps given user input #46456
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46456/42318 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
ping @cms-sw/dqm-l2 |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a quick follow-up to #45795, in which few improvements are added to the tools to generate Tracker maps given user input introduced there:
printPixelROCsMap
,printPixelTrackerMap
,printPixelLayersDisksMap
andprintStripTrackerMap
testPrintTkMaps
)printPixelROCsMap
to accept full, barrel and forward drawing optionsPR validation:
scram b runtests_testPrintTkMaps
runs fine.Example map obtained collecting the bad ROCs for run-386872 in which ROCs 7 and 15 disabled on the Layer1 modules for the full run (see e.g. here and here).
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A