Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plotting utilities to generate Tracker maps given user input #46456

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 20, 2024

PR description:

This PR is a quick follow-up to #45795, in which few improvements are added to the tools to generate Tracker maps given user input introduced there:

  • f47039b adds help functions to printPixelROCsMap, printPixelTrackerMap, printPixelLayersDisksMap and printStripTrackerMap
  • 2931551 adds unit tests (testPrintTkMaps)
  • 8c91a07 improves printPixelROCsMap to accept full, barrel and forward drawing options

PR validation:

scram b runtests_testPrintTkMaps runs fine.

Example map obtained collecting the bad ROCs for run-386872 in which ROCs 7 and 15 disabled on the Layer1 modules for the full run (see e.g. here and here).

Phase1PixelROCMap_barrel

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/TrackerRemapper (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@fioriNTU, @idebruyn, @jandrea, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 20, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-425356/42316/summary.html
COMMIT: 8d5d139
CMSSW: CMSSW_14_2_X_2024-10-20-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46456/42316/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3566331
  • DQMHistoTests: Total failures: 453
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565858
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 201 log files, 171 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 24, 2024

ping @cms-sw/dqm-l2

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5da7d06 into cms-sw:master Oct 24, 2024
11 checks passed
@mmusich mmusich deleted the mm_tkmaps_add-help branch October 24, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants