Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_1_X (2/N) #46376

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 14, 2024

backport of #46375

PR description:

Development of HLT menus for CMSSW_14_1_X

  • This is the PR for the 14_1_X branch which is the release cycle currently used for Run-3 HLT-menu development.

These updates correspond to the changes accumulated in the 14_1_X release cycle for the "PRef V1.0" menu: first menu for the 2024 pp reference data-taking period.

This update includes the integration of the following changes:

  • migration of the combined HLT table and related subtables to CMSSW_14_1_1

In addition we include the integration of the following JIRA tickets:

  • CMSHLT-3325 [HIN] Forward/UPC Triggers request for pp Reference Run 2024
  • CMSHLT-3338 [HIN] Muon Triggers for PbPb Run 2024
  • CMSHLT-3340 [HIN] Jet Triggers for pp Reference Run 2024
  • CMSHLT-3343 [HIN] E/gamma Triggers for pp Reference Run 2024
  • CMSHLT-3345 [HIN] Remove PPRefExotica PD/stream and re-assign paths to PPRefSingleMuon
  • CMSHLT-3346 [HIN] Justify Commissioning{ZDC,RawPrime} PDs in the PRef menu
  • CMSHLT-3348 [HIN] Add two seeds to hltL1sUPCHFafterglowCombined
  • CMSHLT-3350 [HIN] Forward/UPC Triggers request for PbPb Run 2024
  • CMSHLT-3356 [HIN] E/gamma Triggers for PbPb Run 2024
  • CMSHLT-3357 [TSG] Release of special menus V1.6 (for PRef, HIon runs)
  • CMSHLT-3363 [HIN,TSG] Sync offline menu with the 2023 PRef online menu

In this PR we also have the following commits:

  • 9be857b update of L1T HIon menu in TSG GTs to L1Menu_CollisionsHeavyIons2024_v1_0_5_xml
  • 9b44c34 Finalize integration of the following tickets
    • CMSHLT-3310 [TSG] update input files for TSG tests to more modern datasets (2024)
  • 0aaf2a4 Update hltPathOwners.json including paths for menus PRef 2024 V1.0 and HIon 2024 V1.0
  • 2beed13 Bumped version of Paths for HLT PRef-2024 V1.0

PR validation:

TSG Integration tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #46375 to the 2024 PRef and HIon production cycle (CMSSW_14_1_X)

These updates correspond to the changes accumulated in the 14_1_X release cycle for the "PRef V1.0" menu: first menu for the 2024 pp reference data-taking period.

This update includes the integration of the following changes:
- migration of the combined HLT table and related subtables to CMSSW_14_1_1

In addition we include the integration of the following JIRA tickets:

- [CMSHLT-3325](https://its.cern.ch/jira/browse/CMSHLT-3325) [HIN] Forward/UPC Triggers request for pp Reference Run 2024
- [CMSHLT-3338](https://its.cern.ch/jira/browse/CMSHLT-3338) [HIN] Muon Triggers for PbPb Run 2024
- [CMSHLT-3340](https://its.cern.ch/jira/browse/CMSHLT-3340) [HIN] Jet Triggers for pp Reference Run 2024
- [CMSHLT-3343](https://its.cern.ch/jira/browse/CMSHLT-3343) [HIN] E/gamma Triggers for pp Reference Run 2024
- [CMSHLT-3345](https://its.cern.ch/jira/browse/CMSHLT-3345) [HIN] Remove PPRefExotica PD/stream and re-assign paths to PPRefSingleMuon
- [CMSHLT-3346](https://its.cern.ch/jira/browse/CMSHLT-3346) [HIN] Justify Commissioning{ZDC,RawPrime} PDs in the PRef menu
- [CMSHLT-3348](https://its.cern.ch/jira/browse/CMSHLT-3348) [HIN] Add two seeds to hltL1sUPCHFafterglowCombined
- [CMSHLT-3350](https://its.cern.ch/jira/browse/CMSHLT-3350) [HIN] Forward/UPC Triggers request for PbPb Run 2024
- [CMSHLT-3356](https://its.cern.ch/jira/browse/CMSHLT-3356) [HIN] E/gamma Triggers for PbPb Run 2024
- [CMSHLT-3357](https://its.cern.ch/jira/browse/CMSHLT-3357) [TSG] Release of special menus V1.6 (for PRef, HIon runs)
- [CMSHLT-3363](https://its.cern.ch/jira/browse/CMSHLT-3363) [HIN,TSG] Sync offline menu with the 2023 PRef online menu
- [CMSHLT-3310](https://its.cern.ch/jira/browse/CMSHLT-3310) [TSG] update input files for TSG tests to more modern datasets (2024)
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Oct 14, 2024

type hlt-integration

@mmusich
Copy link
Contributor Author

mmusich commented Oct 14, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Oct 14, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 1304KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-983d4f/42175/summary.html
COMMIT: 2beed13
CMSSW: CMSSW_14_1_X_2024-10-14-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46376/42175/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3317891
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3317865
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.728 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 0.104 KiB HLT/Filters
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53015
  • DQMHistoTests: Total failures: 807
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52208
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

+hlt

  • changes in the HLTFilters DQM folders are due the path versioning (2beed13).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

message to @cms-sw/orp-l2, this PR needs to be merged together with #46389

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

@cmsbuild, please abort

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-983d4f/42204/summary.html
COMMIT: 2beed13
CMSSW: CMSSW_14_1_X_2024-10-15-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46376/42204/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 15-Oct-2024 20:01:45 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_HIL2SingleMu0_Centrality40to100_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sSingleMu0Centrality40to100BptxAND'
Exception Message:

Algorithm L1_SingleMu0_Centrality_40_100_BptxAND, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_SingleMu0_Centrality_40_100_BptxAND is present in the L1 menu

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 15-Oct-2024 20:01:47 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_HIL2SingleMu0_Centrality40to100_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sSingleMu0Centrality40to100BptxAND'
Exception Message:

Algorithm L1_SingleMu0_Centrality_40_100_BptxAND, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_SingleMu0_Centrality_40_100_BptxAND is present in the L1 menu

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 15-Oct-2024 20:01:51 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_HIL2SingleMu0_Centrality40to100_v1'
   [2] Calling method for module HLTL1TSeed/'hltL1sSingleMu0Centrality40to100BptxAND'
Exception Message:

Algorithm L1_SingleMu0_Centrality_40_100_BptxAND, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_SingleMu0_Centrality_40_100_BptxAND is present in the L1 menu

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

GPU Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

Ah, now I get it... all the failing workflows are running the 2023 GlobalTag (which wasn't updated in terms of L1T menu). Assuming we don't want to update them to be 2024-like, we should run the fake HLT menu instead. @mandrenguyen any preference?

@mandrenguyen
Copy link
Contributor

Fake would be fine

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

Fake would be fine

see #46399

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

test parameters:

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-983d4f/42217/summary.html
COMMIT: 2beed13
CMSSW: CMSSW_14_1_X_2024-10-15-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46376/42217/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 728 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 517 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4147551
  • DQMHistoTests: Total failures: 3911
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4143620
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.728 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 0.104 KiB HLT/Filters
  • Checked 238 log files, 205 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 8 / 50 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53015
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52985
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Oct 17, 2024

@cms-sw/orp-l2 we need to get going with this PR as there are more tickets to integrate. Please merge at earliest convenience.
About possible IB failures triggered by the update, they will be cured by #46399 - but they are not caused by this particular update here, but from a lack of organization in the HIon relvals structure that can be figured out at a later time.
Thanks your for the collaboration.

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7c90601 into cms-sw:CMSSW_14_1_X Oct 18, 2024
13 checks passed
@mmusich mmusich deleted the HLTdevelopment141X branch October 18, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants