Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X] Update 2023 and 2024 Heavy Ion relval workflows for 2024 HLT menu #46399

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 15, 2024

backport of #46418
backport of #46398

PR description:

PR #46376 updates the HIon HLT menu such that it requires a L1T menu (L1Menu_CollisionsHeavyIons2024_v1_0_5_xml ) different from the one used in 2023 (more L1T seeds are required by trigger paths introduced in the meanwhile, see link to payload inspector [1]).
The goal of this PR is to update the 2023 Heavy Ion relval workflows to use the @fake2 menu and to update the 2024 Heavy Ion workflows to use the updated HIon menu (consequently the DQM and validation steps are updated to run the HLT sequences).

PR validation:

Tested successfully

runTheMatrix.py -l 160,160.02,160.03,160.1,160.2,160.3,160.4,160.501,161,161.02,161.03,161.1,161.2,161.3,161.4,180.0,180.1,181,181.1 --ibeos

also:

runTheMatrix.py -l 330.0, 331.0, 332.0 --ibeos

runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #46398 and #46418 to CMSSW_14_1_X for 2024 HIon operations.


[1]

L1T menu comparison

image

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

test parameters:

  • workflows = 160, 160.02, 160.03, 160.1, 160.2, 160.3, 160.4, 160.501, 161, 161.02, 161.03, 161.1, 161.2, 161.3, 161.4, 180.0, 180.1, 181, 181.1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2024

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Pull request #46399 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47c55d/42223/summary.html
COMMIT: 19b95e7
CMSSW: CMSSW_14_1_X_2024-10-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46399/42223/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1328 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 546 differences found in the comparisons
  • DQMHistoTests: Total files compared: 60
  • DQMHistoTests: Total histograms compared: 4991158
  • DQMHistoTests: Total failures: 1575
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 4989559
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 807419.6660000001 KiB( 59 files compared)
  • DQMHistoSizes: changed ( 161.02,... ): 17547.388 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 161.02,... ): 12810.146 KiB HLT/EGM
  • DQMHistoSizes: changed ( 161.02,... ): 10390.469 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 161.02,... ): 10237.354 KiB HLT/HCAL
  • DQMHistoSizes: changed ( 161.02,... ): 9249.430 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 161.02,... ): 9066.871 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 161.02,... ): 8601.007 KiB HLT/Muon
  • DQMHistoSizes: changed ( 161.02,... ): 8296.829 KiB HLT/BTV
  • DQMHistoSizes: changed ( 161.02,... ): 5317.474 KiB HLT/SUSYBSM
  • DQMHistoSizes: changed ( 161.02,... ): 2757.393 KiB HLT/BPH
  • DQMHistoSizes: changed ( 161.02 ): ...
  • Checked 280 log files, 243 edm output root files, 60 DQM output files
  • TriggerResults: found differences in 16 / 58 workflows

@mandrenguyen
Copy link
Contributor

urgent

@Moanwar
Copy link
Contributor

Moanwar commented Oct 16, 2024

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

Pull request #46399 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 17, 2024

test parameters:

  • workflows = 160, 161, 330.0

@mmusich
Copy link
Contributor Author

mmusich commented Oct 17, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Oct 17, 2024

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 your signature is required again here as I included the commit from #46418

@Moanwar
Copy link
Contributor

Moanwar commented Oct 17, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 60KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47c55d/42257/summary.html
COMMIT: 44f0d0e
CMSSW: CMSSW_14_1_X_2024-10-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46399/42257/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 256 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 73 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3641769
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 3641716
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 201760.30099999998 KiB( 46 files compared)
  • DQMHistoSizes: changed ( 161.0,... ): 17547.388 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 161.0,... ): 12810.146 KiB HLT/EGM
  • DQMHistoSizes: changed ( 161.0,... ): 10390.469 KiB HLT/SiStrip
  • DQMHistoSizes: changed ( 161.0,... ): 10237.354 KiB HLT/HCAL
  • DQMHistoSizes: changed ( 161.0,... ): 9249.430 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 161.0,... ): 9066.871 KiB HLT/Pixel
  • DQMHistoSizes: changed ( 161.0,... ): 8601.007 KiB HLT/Muon
  • DQMHistoSizes: changed ( 161.0,... ): 8296.829 KiB HLT/BTV
  • DQMHistoSizes: changed ( 161.0,... ): 5317.474 KiB HLT/SUSYBSM
  • DQMHistoSizes: changed ( 161.0,... ): 2757.393 KiB HLT/BPH
  • DQMHistoSizes: changed ( 161.0 ): ...
  • Checked 205 log files, 173 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 3 / 45 workflows

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bacc266 into cms-sw:CMSSW_14_1_X Oct 18, 2024
10 checks passed
@mmusich mmusich deleted the mm_dev_2023_2024_HIon_relvals_14_1_X branch October 18, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants