Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure CalibTracker/SiPixelESProducers fake conditions ESProducers #46397

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 15, 2024

PR description:

Full restructuring of CalibTracker/SiPixelESProducers fake conditions ESProducers

  • fold back header files into plugin implementation
  • modernize code, add fillDescriptions
  • add stub of test_catch2_ESSources
  • make plugins in CalibTracker/SiPixelESProducers/test self-contained

improve SiPixelTemplateDBObjectReader

  • add SiPixelTemplateDBObjectReader_cfg.py test in createDBObject test

PR validation:

  • scram b runtests_createDBObjects runs fine
  • scram b runtests_testSiPixelESSources runs fine

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

- add SiPixelTemplateDBObjectReader_cfg.py test in createDBObject test
- fold back header files into plugin implementation
- modernize code
- add stub of test_catch2_ESSources
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CalibTracker/SiPixelESProducers (alca)
  • CondTools/SiPixel (db)

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @VinInn, @dkotlins, @ferencek, @missirol, @mmusich, @mroguljic, @rsreds, @tocheng, @tsusa, @tvami, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 15, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fb8df/42214/summary.html
COMMIT: 0c690c0
CMSSW: CMSSW_14_2_X_2024-10-15-1400/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46397/42214/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 50ecb2c into cms-sw:master Oct 16, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_improveSiPixelTemplateDBObjectReader branch October 16, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants