-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restructure CalibTracker/SiPixelESProducers
fake conditions ESProducer
s
#46397
restructure CalibTracker/SiPixelESProducers
fake conditions ESProducer
s
#46397
Conversation
- add SiPixelTemplateDBObjectReader_cfg.py test in createDBObject test
- fold back header files into plugin implementation - modernize code - add stub of test_catch2_ESSources
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46397/42242 |
A new Pull Request was created by @mmusich for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Full restructuring of
CalibTracker/SiPixelESProducers
fake conditionsESProducer
sfillDescriptions
test_catch2_ESSources
improve
SiPixelTemplateDBObjectReader
SiPixelTemplateDBObjectReader_cfg.py
test increateDBObject
testPR validation:
scram b runtests_createDBObjects
runs finescram b runtests_testSiPixelESSources
runs fineIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A