[vdt]Apply patch to avoid UBSan signed integer overflow error

[smuzaffar]

This should avoid the UBSan runtime errors we see in UBSAN workflows

vdt/0.4.3-820b4286c899d81142fb8526a68cf80f/include/vdt/sincos.h:214:6: runtime error: signed integer overflow: -2147483648 - 2 cannot be represented in type 'int'

[cmsbuild]

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_2_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

test parameters:

• workflow = 136.821
• pull_request = [UBSAN][Math] Suppress signed-integer-overflow for approx_exp cmssw#46417

[smuzaffar]

please test

[smuzaffar]

please test for CMSSW_14_2_UBSAN_X

[cmsbuild]

Pull request #9470 was updated.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42259/summary.html
COMMIT: 8e512ce
CMSSW: CMSSW_14_2_X_2024-10-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9470/42259/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw add CMS_X_SANITIZER macros #9469

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42259/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42259/git-merge-result

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3373249
• DQMHistoTests: Total failures: 416
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3372813
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 197 log files, 166 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[cmsbuild]

-1

Failed Tests: UnitTests AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42261/summary.html
COMMIT: 8e512ce
CMSSW: CMSSW_14_2_UBSAN_X_2024-10-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9470/42261/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @mmusich Update 2023 and 2024 Heavy Ion relval workflows for 2024 HLT menu cmssw#46398
• @mmusich restructure CalibTracker/SiPixelESProducers fake conditions ESProducers cmssw#46397
• @Dr15Jones Issue message if DB IOV updated during job cmssw#46393
• @fabiocos MTD Validation: Add printouts and protection for optional plots in BtlLocalRecoValidation cmssw#46408
• @bsunanda Run3-377C Add the testing code for the ZDC Topology class cmssw#46404
• @mmusich Fix SiStripG2GainsValidator cmssw#46414
• @cms-sw Unify geat4 deps and vecgeom selection #9464
• @cms-sw add CMS_X_SANITIZER macros #9469

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42261/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42261/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testTauEmbeddingWorkflow2018 had ERRORS

AddOn Tests

• unknown

AddOnTest might have timed out: FAILED -  secs

[smuzaffar]

please test for CMSSW_14_2_UBSAN_X

[smuzaffar]

please test

[smuzaffar]

please test

[cmsbuild]

Pull request #9470 was updated.

[smuzaffar]

please test for CMSSW_14_2_UBSAN_X

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42288/summary.html
COMMIT: 9af2fb8
CMSSW: CMSSW_14_2_UBSAN_X_2024-10-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9470/42288/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider [Core] Mark cms::Exception and edm::Exception functions that throw exceptions as noreturn cmssw#46388
• @amecca Porting the Pixel Barycentre tool in the All-in-One framework cmssw#45975
• @perrotta Update the run3_data GT in autoCond to the version intended for the 2022, 2023, 2024CDE rereco cmssw#46420
• @mmusich Update 2023 and 2024 Heavy Ion relval workflows for 2024 HLT menu cmssw#46398
• @mmusich restructure CalibTracker/SiPixelESProducers fake conditions ESProducers cmssw#46397
• @Dr15Jones Issue message if DB IOV updated during job cmssw#46393
• @AdrianoDee New Tests PR Tests for HIN 2023 and 2024 cmssw#46419
• @trackreco Phase-2 mkFit: propagation to plane / Kalman operations on plane / Matriplex with support for scalar operations and VDT cmssw#46325
• @mmusich make {DIGI,RECO}HI2024MIX steps consume the HIon HLT menu cmssw#46418
• @bsunanda Run3-alca249 Modify calibration macros to use the current IsoTrack calibration cmssw#46410
• @fabiocos MTD Validation: Add printouts and protection for optional plots in BtlLocalRecoValidation cmssw#46408
• @bsunanda Run3-377C Add the testing code for the ZDC Topology class cmssw#46404
• @RSalvatico Fix beamspot in PATElectronProducer cmssw#46412
• @mbluj Move "hybrid" tau production from nano to mini step cmssw#46196
• @mmusich Fix SiStripG2GainsValidator cmssw#46414
• @stahlleiton Add dedxLikelihood to 2023 UPC rereco cmssw#46401
• @cms-sw Unify geat4 deps and vecgeom selection #9464
• @cms-sw add CMS_X_SANITIZER macros #9469

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42288/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42288/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test testTauEmbeddingWorkflow2018 had ERRORS

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42287/summary.html
COMMIT: 9af2fb8
CMSSW: CMSSW_14_2_X_2024-10-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9470/42287/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider [Core] Mark cms::Exception and edm::Exception functions that throw exceptions as noreturn cmssw#46388
• @amecca Porting the Pixel Barycentre tool in the All-in-One framework cmssw#45975
• @mbluj Move "hybrid" tau production from nano to mini step cmssw#46196
• @perrotta Update the run3_data GT in autoCond to the version intended for the 2022, 2023, 2024CDE rereco cmssw#46420
• @bsunanda Run3-alca249 Modify calibration macros to use the current IsoTrack calibration cmssw#46410
• @RSalvatico Fix beamspot in PATElectronProducer cmssw#46412
• @stahlleiton Add dedxLikelihood to 2023 UPC rereco cmssw#46401

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42287/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-142b6c/42287/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test TestFWCoreModules had ERRORS

Comparison Summary

Summary:

• You potentially added 30 lines to the logs
• Reco comparison results: 4348 differences found in the comparisons
• DQMHistoTests: Total files compared: 47
• DQMHistoTests: Total histograms compared: 3604451
• DQMHistoTests: Total failures: 1060
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3603371
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
• Checked 205 log files, 174 edm output root files, 47 DQM output files
• TriggerResults: found differences in 2 / 45 workflows