Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD Validation: Add printouts and protection for optional plots in BtlLocalRecoValidation #46408

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

fabiocos
Copy link
Contributor

PR description:

The current BTL digitization, whose revision is ongoing, produces occasionally empty uncalibrated rechits, due to very low energy deposits that are so far digitized. This causes the uncalibrated rechit part of the code, optionally available for uncertainty tuning, to crash. A protection, and printouts useful for inspection/debugging, are added.

PR validation:

Tested on wf 29634.0 by enabling the optionalPlots flag.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 16, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • Validation/MtdValidation (dqm)

@antoniovagnerini, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c145d1/42238/summary.html
COMMIT: 112b938
CMSSW: CMSSW_14_2_X_2024-10-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46408/42238/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 30920f5 into cms-sw:master Oct 17, 2024
11 checks passed
@fabiocos fabiocos deleted the fc-debugbtllocal branch October 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants