MTD geometry: Fix MTDGeometryBuilder text to avoid rounding issues with alternative architectures

[fabiocos]

PR description:

The integration of #46683 is causing failures in the Geometry/MTDGeometryBuilder unit test on both aarch64 and MULTIARCHS builds. This appears an issue with numerical precision. To address it:

• position precision printouts is limited to 2 digits (i.e. 100 microns) for unit test output, while keeping 4 digits in the regular log file for direct inspection;
• the numerical accuracy requited for rotation checks is moved from std::numeric_limits to 10 times as big, to prevent failure on aarch64.

PR validation:

Code runs, provides the desired output, and does not trigger any DIFFERENCE message on lxplus-arm (el9_aarch64_gcc12) vs cmsdev45 (el8_amd64_gcc12). cms-data/Geometry-TestReference reference file is built on the default architecture.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46761/42745

[cmsbuild]

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

• Geometry/MTDGeometryBuilder (geometry, upgrade)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

type mtd

[fabiocos]

type bugfix

[fabiocos]

please test with cms-data/Geometry-TestReference#17

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecbf05/43012/summary.html
COMMIT: 275d4bf
CMSSW: CMSSW_14_2_X_2024-11-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46761/43012/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones avoid holding memory between events in Multi5x5ClusterProducer  #46756
• @rohitcms Add caloParams v0_0 for 2024 HI run #46593
• @smuzaffar [UBSAN][LST]Fix runtime error by keep the region object alive #46758

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecbf05/43012/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecbf05/43012/git-merge-result

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 3050 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 1648
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3482054
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 1 / 44 workflows

[bsunanda]

+geometry

[fabiocos]

please test with cms-data/Geometry-TestReference#17 for CMSSW_15_0_MULTIARCHS_X/el8_amd64_gcc12

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ecbf05/43024/summary.html
COMMIT: 275d4bf
CMSSW: CMSSW_15_0_MULTIARCHS_X_2024-11-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46761/43024/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 279 lines from the logs
• Reco comparison results: 93650 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3483722
• DQMHistoTests: Total failures: 406189
• DQMHistoTests: Total nulls: 583
• DQMHistoTests: Total successes: 3076930
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -4.38 KiB( 45 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.192 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): -1.159 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 2023.002001 ): 0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 2024.000001 ): 0.012 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 2024.303001 ): 0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): -0.416 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.406 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 4.53 ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 7.3 ): -3.051 KiB SiStrip/MechanicalView
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 15 / 44 workflows

[fabiocos]

@cms-sw/upgrade-l2 comments?

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/Geometry-TestReference#17

[mandrenguyen]

+1

[smuzaffar]

cms-data/Geometry-TestReference#17 was needed to go with this PR.